Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Completely remove celery #2730

Merged
merged 13 commits into from
Jan 10, 2022

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 10, 2022

What do these changes do?

Well, celery is completely removed.
Also as celery is gone, there is no need for the Flower application anymore. Thus:
⚠️ devops: remove any entry with Flower in Ops.

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2730 (d8b0ef3) into master (5915b3f) will decrease coverage by 0.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2730     +/-   ##
========================================
- Coverage    78.1%   77.2%   -1.0%     
========================================
  Files         647     640      -7     
  Lines       26657   26460    -197     
  Branches     2581    2560     -21     
========================================
- Hits        20841   20444    -397     
- Misses       5128    5343    +215     
+ Partials      688     673     -15     
Flag Coverage Δ
integrationtests 64.9% <87.5%> (-1.4%) ⬇️
unittests 73.8% <81.2%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_postgres_database/models/comp_pipeline.py 93.3% <ø> (ø)
...src/simcore_postgres_database/models/comp_tasks.py 100.0% <ø> (ø)
.../simcore_service_api_server/models/schemas/jobs.py 93.6% <ø> (ø)
...rc/simcore_service_director_v2/core/application.py 90.7% <ø> (-0.5%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 84.3% <ø> (ø)
...vice_director_v2/modules/comp_scheduler/factory.py 100.0% <ø> (ø)
...2/src/simcore_service_director_v2/core/settings.py 100.0% <100.0%> (+1.7%) ⬆️
...e_service_director_v2/models/domains/comp_tasks.py 100.0% <100.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py 79.4% <100.0%> (ø)
...rc/simcore_service_director_v2/modules/rabbitmq.py 87.7% <100.0%> (ø)
... and 28 more

@sanderegg sanderegg force-pushed the maintenance/remove_celery branch from af40522 to c16309e Compare January 10, 2022 13:45
@sanderegg sanderegg marked this pull request as ready for review January 10, 2022 14:00
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 long live to celery! Probably will see her back soon

Other changes (not in the description)

  • adds settings_library to webserver's requirements
  • using settings_lbirary.RabbitSettings as computation settings

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few library upgrades slipped. Please remove them before merging.

services/director-v2/requirements/_test.txt Outdated Show resolved Hide resolved
@@ -61,26 +49,10 @@ chardet==4.0.0
# aiohttp
charset-normalizer==2.0.8
# via requests
click==7.1.2
click==8.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this slipped through

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be due to the fact that celery was blocking it before? @pcrespov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would also be my guess but I'd do all the upgrades separately in different PRs, as usual.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, no this is a new requirement coming with settings-library so I think that is ok.

Copy link
Member

@pcrespov pcrespov Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case is justified (since it was produce with a target upgrade) and there is no need to create a separate PR for it, provided all tests pass

@@ -12,9 +12,9 @@ bump2version==1.0.1
# via -r requirements/../../../../requirements/devenv.txt
cfgv==3.3.1
# via pre-commit
click==7.1.2
click==8.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another click upgrade

@mguidon
Copy link
Member

mguidon commented Jan 10, 2022

tada long live to celery! Probably will see her back soon

She? Now you confuse me. Hardware is female and software is male, no?

@sanderegg sanderegg merged commit 875b096 into ITISFoundation:master Jan 10, 2022
@sanderegg sanderegg deleted the maintenance/remove_celery branch January 10, 2022 14:54
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-ops-environments that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants