-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes several issues in director-v2 integration test #2626
Merged
sanderegg
merged 29 commits into
ITISFoundation:master
from
pcrespov:maintenance/ci-hanging
Nov 4, 2021
Merged
🐛 Fixes several issues in director-v2 integration test #2626
sanderegg
merged 29 commits into
ITISFoundation:master
from
pcrespov:maintenance/ci-hanging
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2626 +/- ##
========================================
- Coverage 76.1% 74.1% -2.1%
========================================
Files 631 631
Lines 24756 24763 +7
Branches 2432 2433 +1
========================================
- Hits 18860 18358 -502
- Misses 5255 5807 +552
+ Partials 641 598 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Nov 3, 2021
odeimaiz
approved these changes
Nov 3, 2021
sanderegg
approved these changes
Nov 3, 2021
….com/sanderegg/osparc-simcore into maintenance/ci-hanging
…imcore into pcrespov-maintenance/ci-hanging
pcrespov
changed the title
🐛 Fixes endless teardown stage in director-v2 integration test
🐛 Fixes several issues in director-v2 integration test
Nov 3, 2021
GitHK
reviewed
Nov 4, 2021
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/task.py
Show resolved
Hide resolved
services/director-v2/tests/integration/02/test_mixed_dynamic_sidecar_and_legacy_project.py
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
pytest_simcore.docker_swarm.docker_stack
fixture would wait endlessly to networks to be down during tear-down, just after thedocker swarm rm
call. The latter reported an error as weservice_version
->service_tag