-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛♻️ Better context clenup #2586
Merged
GitHK
merged 9 commits into
ITISFoundation:master
from
GitHK:fix-cleanup-run_sequentially_in_context
Oct 20, 2021
Merged
🐛♻️ Better context clenup #2586
GitHK
merged 9 commits into
ITISFoundation:master
from
GitHK:fix-cleanup-run_sequentially_in_context
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
========================================
- Coverage 77.2% 77.1% -0.1%
========================================
Files 619 618 -1
Lines 23944 23910 -34
Branches 2359 2356 -3
========================================
- Hits 18486 18452 -34
+ Misses 4825 4824 -1
- Partials 633 634 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
requested changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition! just one minor thing for readability.
services/director-v2/src/simcore_service_director_v2/core/events.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Oct 18, 2021
pcrespov
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:director-v2
issue related with the director-v2 service
a:services-library
issues on packages/service-libs
bug
buggy, it does not work as expected
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes an issue where the some pending coroutines were not properly cleaned up. Only patched
director-v2
, sincedirector-v0
'sservicelib
is frozen.Related issue/s
How to test
Checklist