-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨♻️🐛 serviceslib[fastapi] and projects tables validation scripts #2550
✨♻️🐛 serviceslib[fastapi] and projects tables validation scripts #2550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2550 +/- ##
======================================
Coverage 76.9% 76.9%
======================================
Files 619 622 +3
Lines 23972 24028 +56
Branches 2345 2355 +10
======================================
+ Hits 18438 18482 +44
- Misses 4908 4918 +10
- Partials 626 628 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c192668
to
3ebd504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup looks very nice.
Below some minor stuff and possible concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very neat!
maybe check the issues with exclusiveMinimum
that looks suspicious
55d4f3d
to
609f400
Compare
609f400
to
09253db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
What do these changes do?
models-library/scripts
a script to validate db projects table exported to a CSVservicelib[fastapi]
package with fastapi-only features (released as servicelib 1.1.0)Makefile
andCI
FastApi.openapi
functools
openapi.json
incatalog
serviceservicelib[fastapi]
_base.*, _packages.*
pytest-simcore
NOTES
requirements
approach. We should look for an simplified approachmodels-library/scripts/validate-pg-projects.py
revealed:Followup in #2552
Related issue/s
How to test
packages/models-library/scripts/ignore.keep
and run a validation scriptignore.keep/