Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 SIMCORE_SERVICES_NETWORK_NAME now allows dashes #2447

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 28, 2021

What do these changes do?

The SIMCORE_SERVICES_NETWORK_NAME is prefixed with the stack name which contains dashes (-):

  • added regression test
  • dashes are now allowed for SIMCORE_SERVICES_NETWORK_NAME

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK added bug buggy, it does not work as expected a:director-v2 issue related with the director-v2 service labels Jul 28, 2021
@GitHK GitHK self-assigned this Jul 28, 2021
@GitHK GitHK added this to the Wombat milestone Jul 28, 2021
@GitHK GitHK requested review from sanderegg and mguidon July 28, 2021 11:14
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #2447 (6f36eb4) into master (fc2f5d3) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2447   +/-   ##
======================================
  Coverage    76.0%   76.0%           
======================================
  Files         574     574           
  Lines       21658   21658           
  Branches     2078    2078           
======================================
+ Hits        16466   16472    +6     
+ Misses       4638    4636    -2     
+ Partials      554     550    -4     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 70.0% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/models-library/src/models_library/services.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/director_v2.py 78.0% <0.0%> (-1.6%) ⬇️
...simcore_service_webserver/projects/projects_api.py 84.4% <0.0%> (-0.4%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 73.3% <0.0%> (+0.8%) ⬆️
.../director/src/simcore_service_director/producer.py 62.3% <0.0%> (+1.0%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 85.7% <0.0%> (+2.0%) ⬆️

@GitHK GitHK requested review from ignapas and odeimaiz July 28, 2021 11:28
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@sanderegg sanderegg merged commit b5ab4b4 into ITISFoundation:master Jul 28, 2021
@GitHK GitHK deleted the fix-network-regex branch July 28, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants