Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Allows port matching from general to concrete data #2385

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

pcrespov
Copy link
Member

What do these changes do?

We will allow matching data:*/* -> data:concrete types in a non-strict check mode. This will allow e.g. connecting a file picker (producing data:*/*) with a sleeper (accepts data:text/plain).

There is obviously a chance that the file produced by the file-picker is not data:text/plain but this API is intended for a first check. Further plausibility checks will use strict mode and detect this failure.

This strict/non-strict approach is convenient for UI/UX purposes.

Related issue/s

How to test

make devenv
source .venv/bin/activate
cd web/server
make install-dev
pytest tests/unit/isolated/test_catalog_api_handlers.py 

Checklist

@pcrespov pcrespov self-assigned this Jun 16, 2021
@pcrespov pcrespov requested review from sanderegg and odeimaiz June 16, 2021 09:36
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jun 16, 2021
@pcrespov pcrespov added this to the Marmoset milestone Jun 16, 2021
@pcrespov pcrespov requested a review from KZzizzle June 16, 2021 09:37
@pcrespov pcrespov force-pushed the is442/fix-port-match branch from 70d50fa to 142276a Compare June 16, 2021 09:40
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2385 (af4356d) into master (cfdf4f8) will increase coverage by 1.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2385     +/-   ##
========================================
+ Coverage    73.4%   74.8%   +1.3%     
========================================
  Files         516     516             
  Lines       20034   20036      +2     
  Branches     1971    1972      +1     
========================================
+ Hits        14724   14990    +266     
+ Misses       4806    4525    -281     
- Partials      504     521     +17     
Flag Coverage Δ
integrationtests 67.3% <33.3%> (+<0.1%) ⬆️
unittests 68.3% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_webserver/catalog_api_handlers.py 38.3% <100.0%> (+2.6%) ⬆️
.../director/src/simcore_service_director/producer.py 61.0% <0.0%> (+0.2%) ⬆️
...simcore_service_webserver/projects/projects_api.py 88.4% <0.0%> (+1.0%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 84.0% <0.0%> (+3.0%) ⬆️
...vices/sidecar/src/simcore_service_sidecar/utils.py 80.0% <0.0%> (+3.6%) ⬆️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 89.7% <0.0%> (+4.4%) ⬆️
...re_service_webserver/projects/projects_handlers.py 90.2% <0.0%> (+7.9%) ⬆️
...ervices/sidecar/src/simcore_service_sidecar/cli.py 67.5% <0.0%> (+10.0%) ⬆️
.../sidecar/src/simcore_service_sidecar/log_parser.py 85.5% <0.0%> (+15.7%) ⬆️
... and 4 more

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jun 16, 2021
Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense - thank you!

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov merged commit c4139ca into ITISFoundation:master Jun 16, 2021
@pcrespov pcrespov deleted the is442/fix-port-match branch June 16, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot link files from File Picker to some cardiac model nodes
3 participants