Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #2368

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 4, 2021

What do these changes do?

  • Error page:

    • Show human friendly error code text
    • More space for displaying entire error message
  • Unresponsive backend:

    • Improve error handling
    • Add "Please, try again later" to 404 and 503 error messages

image
webserverdown

Related issue/s

closes #2283
closes #2350

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jun 4, 2021
@odeimaiz odeimaiz self-assigned this Jun 4, 2021
@odeimaiz odeimaiz changed the title minor Better error rendering Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #2368 (44a7583) into master (c027086) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2368   +/-   ##
======================================
  Coverage    74.9%   74.9%           
======================================
  Files         513     513           
  Lines       20007   20007           
  Branches     1967    1967           
======================================
+ Hits        14998   14999    +1     
+ Misses       4494    4493    -1     
  Partials      515     515           
Flag Coverage Δ
integrationtests 67.4% <ø> (ø)
unittests 68.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/service-library/src/servicelib/aiopg_utils.py 87.5% <0.0%> (-3.2%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 74.0% <0.0%> (+0.8%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 86.0% <0.0%> (+2.0%) ⬆️

@odeimaiz odeimaiz changed the title Better error rendering Better error handling Jun 4, 2021
@odeimaiz odeimaiz marked this pull request as ready for review June 4, 2021 15:32
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did here. It exposes a bit more of the underlying structure, but it works. Thanks a lot for this 👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition!

@odeimaiz odeimaiz merged commit 762494e into ITISFoundation:master Jun 7, 2021
@odeimaiz odeimaiz deleted the feature/nicer-errors branch June 9, 2021 10:44
@odeimaiz odeimaiz added this to the Marmoset milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better error handling when webserver is not ready Enhance display of error message in viewer UI
4 participants