Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minors #2317

Merged
merged 7 commits into from
May 4, 2021
Merged

Minors #2317

merged 7 commits into from
May 4, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 4, 2021

What do these changes do?

  • Classifiers: keep key as is in label
  • Scroll for FolderViewer
  • Removed unused InputsMapper
  • Support enum inputs
  • Bugfix: creating node link after selecting/moving node works again

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label May 4, 2021
@odeimaiz odeimaiz added this to the Schwarznasenschaf milestone May 4, 2021
@odeimaiz odeimaiz self-assigned this May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2317 (6d50eea) into master (77537d4) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2317   +/-   ##
======================================
  Coverage    71.7%   71.7%           
======================================
  Files         506     506           
  Lines       19912   19912           
  Branches     1949    1949           
======================================
+ Hits        14293   14294    +1     
+ Misses       5143    5142    -1     
  Partials      476     476           
Flag Coverage Δ
integrationtests 62.0% <ø> (+<0.1%) ⬆️
unittests 67.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 60.8% <0.0%> (+0.2%) ⬆️

@odeimaiz odeimaiz merged commit c74f23a into ITISFoundation:master May 4, 2021
@odeimaiz odeimaiz deleted the feature/minors branch June 9, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants