-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monkey_patches an issue with Pydantic causing PageLinks validation to fail #2298
Merged
GitHK
merged 18 commits into
ITISFoundation:master
from
GitHK:enable-correct-url-validation
May 1, 2021
Merged
monkey_patches an issue with Pydantic causing PageLinks validation to fail #2298
GitHK
merged 18 commits into
ITISFoundation:master
from
GitHK:enable-correct-url-validation
May 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
added
bug
buggy, it does not work as expected
a:webserver
issue related to the webserver service
labels
Apr 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #2298 +/- ##
======================================
Coverage 71.7% 71.8%
======================================
Files 506 506
Lines 19896 19912 +16
Branches 1947 1949 +2
======================================
+ Hits 14283 14298 +15
Misses 5140 5140
- Partials 473 474 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
approved these changes
Apr 27, 2021
pcrespov
changed the title
monkey_patcges an issue with Pydantic causing PageLinks validation to fail
monkey_patches an issue with Pydantic causing PageLinks validation to fail
Apr 27, 2021
sanderegg
approved these changes
Apr 27, 2021
…rc-simcore-forked into enable-correct-url-validation
The monkey patch must be applied manually inside the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The new dynamic-sidecar requires urls in the following format
http://10.0.0.1.nip.io
for local development, which were not properly handled by Pydantic's url validator.There is an issue with the url validation inside Pydantic. Waiting for this PR pydantic/pydantic#2512 to be properly merged and released.
Related issue/s
required by #1887
How to test
Checklist