Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: infinite studies paginated requests #2294

Merged
merged 8 commits into from
Apr 26, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 26, 2021

What do these changes do?

  • Pagination: Use response._links.next
  • e2e: More accurate waiting times

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Apr 26, 2021
@odeimaiz odeimaiz changed the title bugfix: infinite studies request bugfix: infinite studies paginated requests Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #2294 (5ea8753) into master (9be551a) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2294   +/-   ##
======================================
  Coverage    71.8%   71.8%           
======================================
  Files         504     504           
  Lines       19702   19702           
  Branches     1931    1931           
======================================
+ Hits        14154   14161    +7     
+ Misses       5073    5069    -4     
+ Partials      475     472    -3     
Flag Coverage Δ
integrationtests 62.0% <ø> (+<0.1%) ⬆️
unittests 67.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/garbage_collector.py 75.7% <0.0%> (+0.9%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 88.1% <0.0%> (+5.3%) ⬆️

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing labels Apr 26, 2021
@odeimaiz odeimaiz added this to the Schwarznasenschaf milestone Apr 26, 2021
@odeimaiz odeimaiz merged commit 94439f6 into ITISFoundation:master Apr 26, 2021
@odeimaiz odeimaiz deleted the feature/e2e-timing-request branch August 23, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants