-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is2279/jup lab studies dispatcher (⚠️ devops) #2282
Is2279/jup lab studies dispatcher (⚠️ devops) #2282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
========================================
- Coverage 71.5% 71.5% -0.1%
========================================
Files 486 486
Lines 19244 19270 +26
Branches 1896 1902 +6
========================================
+ Hits 13776 13791 +15
- Misses 5006 5015 +9
- Partials 462 464 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
287e232
to
2a2655b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern: how do we avoid abuse now that guests are allowed?
now? this has always been like that. Actually this PR adds a restriction to that, i.e. some viewers are ONLY accessible to registered users |
1338f84
to
bf9404a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small things to check. cool!
services/web/server/src/simcore_service_webserver/studies_dispatcher/__init__.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/__init__.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/_users.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/handlers_redirects.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/handlers_redirects.py
Show resolved
Hide resolved
8e4d3f5
to
5794812
Compare
What do these changes do?
Studies dispatcher can now dispatch services that consume a file (based on filetype) ONLY if user is registered.
services_consume_filetypes
services_consume_filetypes
with new jupyterlab serviceFollowing this PR
Related issue/s
#2279
How to test
Or manually:
Click any of the link in https://github.com/pcrespov/osparc-sample-studies/tree/master/files%20samples