Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is2279/jup lab studies dispatcher (⚠️ devops) #2282

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 19, 2021

What do these changes do?

Studies dispatcher can now dispatch services that consume a file (based on filetype) ONLY if user is registered.

  • adds extra column to services_consume_filetypes
  • adapts tests, minor fixes and doc
  • @ignapas can you setup please the portal in your computer and point it to master? Are there any dataset example with files having PY and IPYNB extensions?
  • ⚠️ devops: requires updating table services_consume_filetypes with new jupyterlab service
('simcore/services/dynamic/jupyter-octave-python-math',	'1.6.9',	'JupyterLab Math',	'input_1',	'PY',	0,	'0'),
('simcore/services/dynamic/jupyter-octave-python-math',	'1.6.9',	'JupyterLab Math',	'input_1',	'IPYNB',	0,	'0')

Following this PR

Related issue/s

#2279

How to test

cd osparc-simcore
make devenv
source .venv/bin/acticate
cd services/web/server
make install-dev
make test-dev-unit

Or manually:

  • build& start the stack
cd osparc-simcore
make build-x
make up-prod

Click any of the link in https://github.com/pcrespov/osparc-sample-studies/tree/master/files%20samples

@pcrespov pcrespov self-assigned this Apr 19, 2021
@pcrespov pcrespov added this to the Schwarznasenschaf milestone Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #2282 (bc58846) into master (9995faf) will decrease coverage by 0.0%.
The diff coverage is 80.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2282     +/-   ##
========================================
- Coverage    71.5%   71.5%   -0.1%     
========================================
  Files         486     486             
  Lines       19244   19270     +26     
  Branches     1896    1902      +6     
========================================
+ Hits        13776   13791     +15     
- Misses       5006    5015      +9     
- Partials      462     464      +2     
Flag Coverage Δ
integrationtests 62.1% <34.7%> (-0.1%) ⬇️
unittests 66.7% <80.5%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gres_database/models/services_consume_filetypes.py 100.0% <ø> (ø)
...e_service_webserver/studies_dispatcher/__init__.py 100.0% <ø> (ø)
..._service_webserver/studies_dispatcher/_projects.py 88.0% <ø> (ø)
...ore_service_webserver/studies_dispatcher/_users.py 76.2% <64.7%> (-2.7%) ⬇️
...core_service_webserver/studies_dispatcher/_core.py 80.2% <78.2%> (-9.2%) ⬇️
...webserver/studies_dispatcher/handlers_redirects.py 85.3% <86.9%> (-0.4%) ⬇️
.../server/src/simcore_service_webserver/constants.py 100.0% <100.0%> (ø)
...rc/simcore_service_webserver/login/module_setup.py 90.4% <100.0%> (-0.3%) ⬇️
...eb/server/src/simcore_service_webserver/statics.py 88.3% <100.0%> (-0.2%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 88.6% <100.0%> (-0.3%) ⬇️
... and 5 more

@pcrespov pcrespov force-pushed the is2279/jupLab-studies-dispatcher branch from 287e232 to 2a2655b Compare April 21, 2021 04:03
@pcrespov pcrespov changed the title WIP: Is2279/jup lab studies dispatcher Is2279/jup lab studies dispatcher Apr 21, 2021
@pcrespov pcrespov requested review from sanderegg, GitHK, odeimaiz and ignapas and removed request for sanderegg April 21, 2021 11:19
@pcrespov pcrespov marked this pull request as ready for review April 21, 2021 11:19
@pcrespov pcrespov changed the title Is2279/jup lab studies dispatcher Is2279/jup lab studies dispatcher (⚠️ devops) Apr 21, 2021
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Apr 21, 2021
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern: how do we avoid abuse now that guests are allowed?

@pcrespov
Copy link
Member Author

now that guests are allowed?

now? this has always been like that. Actually this PR adds a restriction to that, i.e. some viewers are ONLY accessible to registered users

@pcrespov pcrespov requested a review from GitHK April 22, 2021 14:44
@pcrespov pcrespov force-pushed the is2279/jupLab-studies-dispatcher branch from 1338f84 to bf9404a Compare April 22, 2021 14:44
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things to check. cool!

@pcrespov pcrespov force-pushed the is2279/jupLab-studies-dispatcher branch from 8e4d3f5 to 5794812 Compare April 22, 2021 18:57
@pcrespov pcrespov merged commit 486f316 into ITISFoundation:master Apr 22, 2021
@pcrespov pcrespov deleted the is2279/jupLab-studies-dispatcher branch April 22, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants