Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes several issues in director-v2 integration test #2626

Merged
merged 29 commits into from
Nov 4, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 3, 2021

What do these changes do?

  • pytest_simcore.docker_swarm.docker_stack fixture would wait endlessly to networks to be down during tear-down, just after the docker swarm rm call. The latter reported an error as we
    • Added a limited retry
    • Fixes logs in
    • logs problematic resources
  • redirection to director is faulty:
    • redirection to director ends in director-v2 /run_interactive which had different query entry service_version -> service_tag
    • httpx client has problems to redirect in the test
  • merges changes from PR ♻️ Maintenance/improve test reliability #2623

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #2626 (108661d) into master (2d19a43) will decrease coverage by 2.0%.
The diff coverage is 84.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2626     +/-   ##
========================================
- Coverage    76.1%   74.1%   -2.1%     
========================================
  Files         631     631             
  Lines       24756   24763      +7     
  Branches     2432    2433      +1     
========================================
- Hits        18860   18358    -502     
- Misses       5255    5807    +552     
+ Partials      641     598     -43     
Flag Coverage Δ
integrationtests 60.8% <70.8%> (-2.3%) ⬇️
unittests 70.1% <80.0%> (-1.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice_director_v2/api/routes/running_interactive.py 93.7% <ø> (+12.5%) ⬆️
...er/src/simcore_service_webserver/exporter/utils.py 60.0% <0.0%> (-33.4%) ⬇️
...re_service_webserver/projects/projects_handlers.py 82.9% <ø> (-0.5%) ⬇️
...simcore_service_webserver/projects/projects_api.py 79.0% <57.1%> (-5.8%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 89.2% <100.0%> (-0.3%) ⬇️
...rvice_dynamic_sidecar/modules/directory_watcher.py 92.5% <100.0%> (-1.9%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 85.7% <100.0%> (ø)
...ce_webserver/resource_manager/websocket_manager.py 94.6% <100.0%> (-2.6%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 25.0% <0.0%> (-64.8%) ⬇️
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-61.0%) ⬇️
... and 43 more

@pcrespov pcrespov self-assigned this Nov 3, 2021
@pcrespov pcrespov added this to the Anti-PER milestone Nov 3, 2021
@pcrespov pcrespov marked this pull request as ready for review November 3, 2021 15:22
@pcrespov pcrespov changed the title 🐛 Fixes endless teardown stage in director-v2 integration test 🐛 Fixes several issues in director-v2 integration test Nov 3, 2021
@sanderegg sanderegg merged commit 844cb17 into ITISFoundation:master Nov 4, 2021
@pcrespov pcrespov deleted the maintenance/ci-hanging branch November 4, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants