-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🗑️ ⬆️ Propagate server-side changes to client #156
Merged
bisgaard-itis
merged 151 commits into
ITISFoundation:master
from
bisgaard-itis:update-openapi-json
Jun 5, 2024
Merged
✨🗑️ ⬆️ Propagate server-side changes to client #156
bisgaard-itis
merged 151 commits into
ITISFoundation:master
from
bisgaard-itis:update-openapi-json
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisgaard-itis
changed the title
✨🗑️ Update openapi json
✨🗑️ ⬆️ Propagate server-side changes to client
Jun 4, 2024
pcrespov
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why you want to go to 3.8 :-).
thx for the extra effort! Greatly appreciated!
sanderegg
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks a lot, a few comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a (not entirely clean) PR to propagate several server-side changes to the client. Here is a list of these:
openapi.json
so client automatically passesparent_project_uuid
andparent_node_id
to server when they are in the environment. To do this,pydantic
andpydantic-settings
are added as dependencies.files
section to "production mode" (meaning they are no longer in dev-mode). These have already been used for a long time onsim4life.io
so I think it is about time they are also reflected here.osparc.models
module which was deprecated a long time ago.Related issue/s
How to test
For internal developers