Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🗑️ ⬆️ Propagate server-side changes to client #156

Merged
merged 151 commits into from
Jun 5, 2024

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Jun 4, 2024

What do these changes do?

This is a (not entirely clean) PR to propagate several server-side changes to the client. Here is a list of these:

  • Update openapi.json so client automatically passes parent_project_uuid and parent_node_id to server when they are in the environment. To do this, pydantic and pydantic-settings are added as dependencies.
  • Move all endpoints in the files section to "production mode" (meaning they are no longer in dev-mode). These have already been used for a long time on sim4life.io so I think it is about time they are also reflected here.
  • Delete osparc.models module which was deprecated a long time ago.
  • Remove testing with python 3.6 and 3.7 and add testing with 3.10 to github actions

Related issue/s

How to test

cd clients/python && make install-unit-test && cd test/test_osparc && python -m pytest .

For internal developers

bisgaard-itis and others added 30 commits October 23, 2023 11:33
@bisgaard-itis bisgaard-itis self-assigned this Jun 4, 2024
@bisgaard-itis bisgaard-itis added enhancement New feature or request add test Add more tests labels Jun 4, 2024
@bisgaard-itis bisgaard-itis added this to the The Next One milestone Jun 4, 2024
@bisgaard-itis bisgaard-itis changed the title ✨🗑️ Update openapi json ✨🗑️ ⬆️ Propagate server-side changes to client Jun 4, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review June 4, 2024 09:04
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner June 4, 2024 09:04
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you want to go to 3.8 :-).
thx for the extra effort! Greatly appreciated!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks a lot, a few comments.

clients/python/client/osparc/_models.py Outdated Show resolved Hide resolved
clients/python/client/osparc/_models.py Outdated Show resolved Hide resolved
clients/python/test/test_osparc/conftest.py Outdated Show resolved Hide resolved
clients/python/test/test_osparc/test_apis.py Outdated Show resolved Hide resolved
@bisgaard-itis bisgaard-itis merged commit 2e16b48 into ITISFoundation:master Jun 5, 2024
8 checks passed
@bisgaard-itis bisgaard-itis deleted the update-openapi-json branch June 5, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add test Add more tests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt PublicAPI/Python client to automatically set the parent project UUID and node ID
3 participants