Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixes pressing CTRL-C not killing a script after reset layout is pressed.
Ticket
ISISComputingGroup/IBEX#4736
I also found I needed to fix ISISComputingGroup/IBEX#3773 as part of this work, because using placeholders otherwise makes it easier for the console to become misplaced. So you should no longer be able to make the console view appear in the wrong perspective now.
Acceptance criteria
while True: pass
while True: pass
Verify that this process does not work on master
Unit tests
N/a tightly bound to E4 UI semantics
Documentation
https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Eclipse-RCP#e4-and-compatibility-views-eg-orgeclipseuiconsole
Code Review
Final Steps