Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket4736 ctrl c #996

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Ticket4736 ctrl c #996

merged 4 commits into from
Nov 29, 2019

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Nov 28, 2019

Description of work

Fixes pressing CTRL-C not killing a script after reset layout is pressed.

Ticket

ISISComputingGroup/IBEX#4736

I also found I needed to fix ISISComputingGroup/IBEX#3773 as part of this work, because using placeholders otherwise makes it easier for the console to become misplaced. So you should no longer be able to make the console view appear in the wrong perspective now.

Acceptance criteria

  • Open scripting window
  • type while True: pass
  • Press ctrl-c to terminate the script
  • press the reset layout button
  • type while True: pass
  • Press ctrl-c to terminate the script
  • Verify that the script terminates

Verify that this process does not work on master

Unit tests

N/a tightly bound to E4 UI semantics

Documentation

https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Eclipse-RCP#e4-and-compatibility-views-eg-orgeclipseuiconsole


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI/BUG: Scripting window appearing in non-scripting views
2 participants