Ticket2397 emma fermi chopper

[Tom-Willemsen]

Description of work

Adds an OPI for the EMMA fermi chopper (SKF MB350 PC)

Ticket

ISISComputingGroup/IBEX#2397

Acceptance criteria

• OPI looks appropriate and the layout is intuitive.
• OPI contains the same controls at the existing VI
  • Note, the labview has at least one "hidden" indicator
  • Note, the IOC is one IOC per controller so does not need the tabbed view

Unit tests

This in an OPI, unit tests not applicable.

System tests

GUI system tests not applicable for OPIs.

Documentation

See IOC pull request for details.

---

Code Review

• Is the code of an acceptable quality?
• Do the changes function as described and is it robust?
• Have the changes been documented in the release notes?

Final Steps

• Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

[John-Holt-Tessella]

On OPI:

• Phase accuracy -> Phase on OPI
• Phase Accuracy window -> either Phase error (change PV to PHAS_ERR) or ir is GATE:SP:RBV and should be moved to be by phase window in nominal parameters
• Consider using PHASE_ERR:SP for GATE:SP not sure if this is correct see mk3chopper and skf G5