Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for array index out of bounds #1755

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Chsudeepta
Copy link
Contributor

@Chsudeepta Chsudeepta commented Dec 9, 2024

Description of work

This PR fixes the ticket

To replicate the issue, go to DAE screen, "Experiment Setup" Tab and click on the "Periods" subtab.

Acceptance criteria

  • The code should follow the coding standards
  • The array index out of bounds shouldn't come when DAE experiment setup is done
  • Code should build without errors including checkstyle issues.

Code Review

Final Steps

Copy link
Contributor

@iangillingham-stfc iangillingham-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR look correct and it's surprising it ever worked, given that thet rowIndex was reset on every iteration.
As a general comment, table.getColumnCount() is being called repeatedly, it would be better to call it once at the beginning and store the value in a local stack variable.

@iangillingham-stfc iangillingham-stfc merged commit d2a3aa4 into master Jan 8, 2025
1 check passed
@iangillingham-stfc iangillingham-stfc deleted the Ticket8568_ArrayIndexExceptionFix branch January 8, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI dae: make more robust [Timebox 1.5 days]
2 participants