Ticket7515

[NikolaRoev]

Ticket

ISISComputingGroup/IBEX#7515

Acceptance criteria

See ticket.

---

Code Review

• Is the code of an acceptable quality?
• If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
• Do the changes function as described and is it robust?
• Is there associated PR for the release notes?

Final Steps

• Reviewer has also merged the release notes

[Tom-Willemsen]

• I think if either the source or the destination server versions start with 0.0.0, then we should consider these "development versions", assume they're up-to-date, and always allow an import (with a suitable warning message about possible version incompatibilities). This would make it much easier for developers to test locally, too.
• We are leaking various observers / listeners due to not unsubscribing them, and them being created each time the dialog is opened. We either need to wrap these in some kind of singleton, so that they are only created once, or the better solution is to unsubscribe each listener when it's no longer required.
  • You can see this easily for example by going to VisualVM, and using the "memory sampler" to track the instance count of StringChannel (or various other classes). Each time the dialog is opened a new instance is created and not removed - this is a memory leak. See https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Debugging-memory-leaks-in-the-IBEX-GUI#observables for some more info.
• It would be nice to be able to select a "custom instrument" manually for testing purposes or in case the instrument list PV is unavailable - just like in the instrument selection dialog, you can put in your own arbitrary PV prefix to change to an instrument not on inst list
• I think this is complex enough to need a system test. If you can think of a nice way to test with squish, do that, otherwise add a test or two to the manual system tests spreadsheet that exercise this functionality in the same way that a user would.