Ticket7225

[NikolaRoev]

Description of work

Separated component groups from configuration groups.

Ticket

ISISComputingGroup/IBEX#7225

Acceptance criteria

See ticket.

Unit tests

Added a test to see if component groups are correctly added to an EditableConfiguration.

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer

---

Code Review

• Is the code of an acceptable quality?
• If the change is to an OPI, does the check_opi_format.py script in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?
• Do the changes function as described and is it robust?
• Is there associated PR for the release notes?

Final Steps

• Reviewer has also merged the release notes

[Tom-Willemsen]

• Please make sure you are adding unit tests for new logic - I can't see any as part of this PR. Did you forget to commit them?

[Tom-Willemsen]

I have two components - comp_a and comp_b - each defines a block and a group.

But it looks like if I add those components to my config, the GUI looks like it would let me add comp_a_block to a different group (but doesn't actually work on save).

I think we need to filter out blocks defined in components from the config-level group editor

(please also add tests for these cases)

[Tom-Willemsen]

For blocks not in a group the current code adds a fake "NONE" group, I think this needs filtering out: