Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket5069 #1238

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Ticket5069 #1238

merged 3 commits into from
Feb 5, 2021

Conversation

JamesKingWork
Copy link
Contributor

Description of work

Add configuresBlockGWAndArchiver tag to the client because of the way the block server saves the config (clears all fields of its config and repopulates the fields with what the client has sent). This way the client receives the tag and sends its back but we can't edit it from the gui (something we could add later if we wanted).

To test:

  • Create a config with the tag configuresBlockGWAndArchiver as true
  • Ensure it is loaded as the current config
  • Check the client log to see that the tag configuresBlockGWAndArchiver is set as true in the client
  • Edit the current configuration (you don't have to make any changes)
  • Save the config
  • Check the configuresBlockGWAndArchiver tag is still true in the meta.xml of the config

Ticket

ISISComputingGroup/IBEX#5069

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Is there associated PR for the release notes?

Final Steps

@John-Holt-Tessella John-Holt-Tessella merged commit 604537b into master Feb 5, 2021
@John-Holt-Tessella John-Holt-Tessella deleted the Ticket5069 branch February 5, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants