Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIKEN: Enable control of Line Valves from Vacuum Overview OPI #7700

Closed
davidkeymer opened this issue Apr 12, 2023 · 3 comments
Closed

RIKEN: Enable control of Line Valves from Vacuum Overview OPI #7700

davidkeymer opened this issue Apr 12, 2023 · 3 comments
Assignees
Labels
1 no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@davidkeymer
Copy link
Contributor

davidkeymer commented Apr 12, 2023

As a RIKEN instrument scientist, I would like to be able to remotely control the seven line valves in the vacuum system.

This feature was always originally intended, and yet it was missed from the implementation in 5878 and 7629 because it wasn't clearly specified. Also it may have been missed due to the number of people who have worked on the tickets.

Acceptance Criterion

  • The valve icons need to be clickable and then trigger the PV

Notes

  • Only remote OPENING is allowed by the PLC
  • Records already exist in the RIKEN DB [C:\Instrument\Apps\EPICS\ioc\master\SCHNDR\db\RIKENFE.db] of the Schneider PLC IOC [LV(1..7):OPEN:SP] - a record for each valve needs to be forced to process (.PROC field written to) to trigger a falling edge sequence which the PLC detects and subsequently opens the valve, subject to safety conditions.
@KathrynBaker
Copy link
Member

Not quite a flash review due to the complexity of the OPI

@KathrynBaker KathrynBaker added the 2 label Apr 13, 2023
@github-actions github-actions bot added ready and removed proposal labels Apr 13, 2023
@KathrynBaker KathrynBaker added this to the SPRINT_2023_04_13 milestone Apr 13, 2023
@LowriJenkins LowriJenkins self-assigned this Apr 19, 2023
@LowriJenkins LowriJenkins added the no_release_notes Tickets that do not need release notes, use sparingly! label Jun 5, 2023
@LowriJenkins
Copy link
Contributor

Should be reviewed by david due to being on the branch with other requested riken fixes.
ISISComputingGroup/ibex_gui#1546
no release notes as it is covered by the notes that this opi is being added.

@KathrynBaker KathrynBaker added this to the SPRINT_2023_07_13 milestone Jul 13, 2023
@davidkeymer
Copy link
Contributor Author

IS confirmed all updates functioning as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Development

No branches or pull requests

3 participants