Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beckhoff/tcioc: use status for limits not raw inputs #7506

Closed
rerpha opened this issue Nov 30, 2022 · 4 comments
Closed

Beckhoff/tcioc: use status for limits not raw inputs #7506

rerpha opened this issue Nov 30, 2022 · 4 comments
Assignees
@rerpha
Labels
2 no_release_notes Tickets that do not need release notes, use sparingly!
Milestone
SPRINT_2022_11_24

Comments

@rerpha
Copy link
Contributor

rerpha commented Nov 30, 2022 •
edited
Loading

Currently we use STINPUTS-BLIMITFWD/BWD which are the raw inputs for a limit switch, but limits have been added to the standard status array - we should instead use stStatus.bFwEnabled and stStatus.bBwEnabled

the nice bit about this is unit tests that set limits can stay the same as they are setting the stinput fields which stStatus.bfw/bbwenabled use.
@rerpha rerpha self-assigned this Nov 30, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Nov 30, 2022 •
edited
Loading

#7509
ISISComputingGroup/EPICS-tcIoc#20

@rerpha rerpha changed the title Beckhoff/tcioc: use status limits not raw inputs Beckhoff/tcioc: use status for limits not raw inputs Nov 30, 2022
@rerpha rerpha added the 2 label Nov 30, 2022
@rerpha rerpha added this to the SPRINT_2022_11_24 milestone Nov 30, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Dec 1, 2022

to review run tests as described in https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Beckhoff-testing#building-simulating-and-testing-the-code - the existing limits test should still pass

This was referenced Dec 2, 2022
Closed
Closed
@LilithCole
Copy link
Contributor

All changes look sound, functionality should be checked with existing tests, so would be happy to push through if the next reviewer could run the tests. (BUT be sure to only install 4024.11 twincat otherwise the test runner won't work, hence my abandoning of the review).

@rerpha
Copy link
Contributor Author

rerpha commented Dec 20, 2022

now superceded by #7522 which includes the changes

@rerpha rerpha closed this as completed Dec 20, 2022
@rerpha rerpha added the no_release_notes Tickets that do not need release notes, use sparingly! label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerpha rerpha

Labels
2 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Milestone
SPRINT_2022_11_24
Development

No branches or pull requests
3 participants
@KathrynBaker @rerpha @LilithCole