Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEARL Pressure Controller: Test Hardware #6762

Closed
3 tasks
JackEAllen opened this issue Sep 14, 2021 · 5 comments
Closed
3 tasks

PEARL Pressure Controller: Test Hardware #6762

JackEAllen opened this issue Sep 14, 2021 · 5 comments
Assignees
Labels
5 no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@JackEAllen
Copy link
Member

JackEAllen commented Sep 14, 2021

As a: developer

I would like communicate with both PEARL and WISH to arrange a time to test the Pearl pressure controller. This should be done after testing with the emulator #7114

Acceptance Criteria

  • Ensure EPICS logic written as part of PEARL: IOC & OPI for Pressure Controller #6040 behaves as expected against PEARL pressure controller hardware.
  • Logic not handled by the device is correctly documented and placed into new issues where appropriate to align with functionality of existing LabView VI implementation.
  • Ensure OPI screen in IBEX displays information as expected when testing hardware.

Extra Information

Why it is needed?
In order to correctly develop the IOC and OPI, testing of the hardware is required to ensure that work completed as part of #6040 works as expected.
Testing the hardware will also gain insight into what is device specific controller logic and what needs to be developed further using DB logic as the separation between the two is not incredibly clear in the Manual.
Once a clear separation of logic is known and documented, work can continue with adding functionality to PEARLPC OPI device screen which reflects LabView VI functionality.

Where required files/links are

  • Manual: \\isis\shares\ISIS_Experiment_Controls\Manuals\PEARL Pressure Controller\PEARL handbook_v3_5.docx
  • Labview Vi: C:\LabVIEW Modules\Instruments\PEARL\PEARL Pressure Cell Controller
  • Please see conversation in PEARL: IOC & OPI for Pressure Controller #6040 to view a screenshot of LabView VI for reference.
  • PEARL Pressure Controller Emulator: C:\Instrument\Apps\EPICS\support\PearlPressureController\master
  • PEARL Pressure Controller IOC: C:\Instrument\Apps\EPICS\ioc\master\PEARLPC
  • PEARL Pressure Controller OPI: C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis\resources
@rerpha rerpha added the 8 label Feb 24, 2022
@github-actions github-actions bot added the bucket proposals that didn't make into the sprint label Feb 24, 2022
@KathrynBaker KathrynBaker added bucket proposals that didn't make into the sprint and removed bucket proposals that didn't make into the sprint labels May 19, 2022
@github-actions github-actions bot removed proposal bucket proposals that didn't make into the sprint labels Jun 16, 2022
@rerpha
Copy link
Contributor

rerpha commented Jun 23, 2022

Minor issue spotted - LAST_ERR didn't seem to match up with the error code at least in the case of the errcode being 6 which should correlate to "General Error" - the LED was on for GENERAL_ERROR. I did have a quick look with nothing that obvious in the code. I can spin out a ticket but i'm tempted to wait and see if there are any other errors found by the IS before doing so

@Tom-Willemsen
Copy link
Contributor

@rerpha I'll have a look at that issue this afternoon.

@Tom-Willemsen
Copy link
Contributor

Device was tested this morning on WISH. Communicated fine apart from issue described above (fixed in PR). Configs and scripts written on WISH with scientist, and scientist is happy that system was behaving as expected.

@FreddieAkeroyd
Copy link
Member

@rerpha @Tom-Willemsen As far as we know this has worked fine other than the minor error code fix in the PR?

@rerpha
Copy link
Contributor

rerpha commented Jul 1, 2022

@rerpha @Tom-Willemsen As far as we know this has worked fine other than the minor error code fix in the PR?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Development

No branches or pull requests

7 participants