Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HVCAEN OPI: Improvements for MuSR #6404

Closed
4 tasks
JamesKingWork opened this issue Apr 15, 2021 · 3 comments
Closed
4 tasks

HVCAEN OPI: Improvements for MuSR #6404

JamesKingWork opened this issue Apr 15, 2021 · 3 comments
Assignees
Labels

Comments

@JamesKingWork
Copy link
Contributor

As a MuSR scientist, I would like my device screen for the HVCAEN to be as good as SECI.

Acceptance criteria:

  • Investigate differences between Labview VI for HVCAEN and IBEX OPI
  • Discuss with MuSR scientists what they would like from the OPI
  • Decide on changes to be made to OPI
  • Make changes

Notes:

@JamesKingWork
Copy link
Contributor Author

VI picture for reference:

image

@KathrynBaker KathrynBaker added the 3 label Oct 6, 2022
@github-actions github-actions bot added ready and removed proposal labels Oct 6, 2022
@KathrynBaker KathrynBaker added this to the SPRINT_2022_10_06 milestone Oct 6, 2022
@Tom-Willemsen Tom-Willemsen self-assigned this Oct 13, 2022
@Tom-Willemsen
Copy link
Contributor

Have implemented a draft OPI with roughly equivalent functionality to existing Labview VI and have sent screenshots to scientist for feedback. Will put this in impeded for the moment waiting for scientist response.

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Oct 24, 2022

PRs:

  • Ticket6404 musr caen improvements ibex_gui#1495
  • MuSR caen - add tolerance PVs EPICS-HVCAENx527#12
  • Ticket6404 #7438
  • Have added a task to ensure the detectors that I've put in custom_records.db below match detectors starting with det-* - I can't tell this at the moment as MuSR is off.
  • This is tricky to test in an automated way as the HVCAEN Simulated IOC isn't very capable, but I think writing an entire emulator for it is out of scope for this ticket (especially given that it's a vendor DLL-driver). Task created to test with hardware on MuSR and make sure scientists are happy.
  • Email exchange with scientists containing some feedback from an initial draft is available at \\isis\shares\ISIS_Experiment_Controls\data for tickets\Ticket6404
  • Add the following to MuSR's custom_records.db in their configs area:
record(calc, "$(P)CAEN:ALL_IN_TOL") {
    field(INPA, "$(P)CAEN:ALL_IN_TOL:1 CP MSS")
    field(INPB, "$(P)CAEN:ALL_IN_TOL:2 CP MSS")
    field(INPC, "$(P)CAEN:ALL_IN_TOL:3 CP MSS")
    field(INPD, "$(P)CAEN:ALL_IN_TOL:4 CP MSS")
    field(INPE, "$(P)CAEN:ALL_IN_TOL:5 CP MSS")
    field(INPF, "$(P)CAEN:ALL_IN_TOL:6 CP MSS")
	field(CALC, "A&&B&&C&&D&&E&&F")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:1") {
    field(INPA, "$(P)CAEN:hv0:0:0:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:0:1:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:0:2:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:0:3:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:0:4:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:0:5:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:0:6:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:0:7:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:0:8:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:0:9:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:0:10:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:0:11:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:2") {
    field(INPA, "$(P)CAEN:hv0:0:12:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:0:13:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:0:14:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:0:15:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:0:16:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:0:17:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:0:18:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:0:19:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:0:20:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:0:21:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:0:22:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:0:23:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:3") {
    field(INPA, "$(P)CAEN:hv0:4:0:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:4:1:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:4:2:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:4:3:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:4:4:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:4:5:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:4:6:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:4:7:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:4:8:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:4:9:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:4:10:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:4:11:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:4") {
    field(INPA, "$(P)CAEN:hv0:4:12:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:4:13:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:4:14:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:4:15:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:4:16:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:4:17:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:4:18:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:4:19:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:4:20:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:4:21:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:4:22:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:4:23:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:3") {
    field(INPA, "$(P)CAEN:hv0:12:0:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:12:1:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:12:2:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:12:3:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:12:4:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:12:5:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:12:6:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:12:7:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:12:8:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:12:9:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:12:10:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:12:11:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

record(calc, "$(P)CAEN:ALL_IN_TOL:4") {
    field(INPA, "$(P)CAEN:hv0:12:12:intol CP MSS")
    field(INPB, "$(P)CAEN:hv0:12:13:intol CP MSS")
    field(INPC, "$(P)CAEN:hv0:12:14:intol CP MSS")
    field(INPD, "$(P)CAEN:hv0:12:15:intol CP MSS")
    field(INPE, "$(P)CAEN:hv0:12:16:intol CP MSS")
    field(INPF, "$(P)CAEN:hv0:12:17:intol CP MSS")
    field(INPG, "$(P)CAEN:hv0:12:18:intol CP MSS")
    field(INPH, "$(P)CAEN:hv0:12:19:intol CP MSS")
    field(INPI, "$(P)CAEN:hv0:12:20:intol CP MSS")
    field(INPJ, "$(P)CAEN:hv0:12:21:intol CP MSS")
    field(INPK, "$(P)CAEN:hv0:12:22:intol CP MSS")
    field(INPL, "$(P)CAEN:hv0:12:23:intol CP MSS")
    field(CALC, "A&&B&&C&&D&&E&&F&&G&&H&&I&&J&&K&&L")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants