Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Generator: Estimate Measurement Duration #5964

Closed
kjwoodsISIS opened this issue Dec 11, 2020 · 10 comments
Closed

Script Generator: Estimate Measurement Duration #5964

kjwoodsISIS opened this issue Dec 11, 2020 · 10 comments

Comments

@kjwoodsISIS
Copy link
Contributor

As a user, I would like the Script Generator to provide an estimate of the duration of a measurement, based on a rate that I provide.

Acceptance Criteria

  1. I can provide a rate for each measurement in my script.
  2. The Script Generator calculates an estimated duration for each measurement

Notes

  1. This feature is particularly requested by the muons group. The old script generator had this facility.
@John-Holt-Tessella
Copy link
Contributor

How is this different from the estimated time facility?

@kjwoodsISIS
Copy link
Contributor Author

kjwoodsISIS commented Dec 11, 2020

It probably isn't. When I looked for a ticket with a "estimated time facility", I couldn't find one - most likely I just missed it.

@John-Holt-Tessella
Copy link
Contributor

John-Holt-Tessella commented Dec 11, 2020

I believe it is already implemented #4172

@kjwoodsISIS
Copy link
Contributor Author

Well, that's interesting! The muons don't seem to know about it.

@John-Holt-Tessella
Copy link
Contributor

John-Holt-Tessella commented Dec 11, 2020

In which case maybe we should change this ticket to let the muons know they can use time estimates in their scripts.

@DominicOram
Copy link
Contributor

I think the issue is actually #5616. The time estimation does not work for them because they need to set a global rate for the whole script. I believe we can close this ticket in favour of proposing #5616

@JamesKingWork
Copy link
Contributor

When it says "I can provide a rate" does it mean the user can provide a rate or it is provided by the script definition?

@DominicOram
Copy link
Contributor

The user. They want a box at the top of the view that they put a constant in and this constant will then be used by every line of the script to do the time estimation

@John-Holt-Tessella
Copy link
Contributor

Is it ok to close this for the more general #5616?

@kjwoodsISIS
Copy link
Contributor Author

Closed as a duplicate of #5616.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants