Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script generator: time estimation #4172

Closed
Tom-Willemsen opened this issue Mar 20, 2019 · 10 comments
Closed

Script generator: time estimation #4172

Tom-Willemsen opened this issue Mar 20, 2019 · 10 comments
Assignees
Labels
0 fixed re-requested Issue that has been requested again by a user. rework training

Comments

@Tom-Willemsen
Copy link
Contributor

Tom-Willemsen commented Mar 20, 2019

As a user, I would like the script generator to provide time estimates.

Acceptance criteria:

  • As a user I get a total time estimate for scripts generated in the script generator
  • As a user I get a time estimate for each row of the script generator (for example, an extra column which displays the estimated time).
  • As a scientist, I can define a relationship between the script generator parameters and the estimated time.

Notes:

  • We will need to make some assumptions (e.g. beam rates)
  • These assumptions may be instrument specific, so should be able to be changed by scientists (getting a sample to temperature may take longer on one instrument than another)

Suggested implementation: another function in the script generator config files, similar to parameters_valid, which takes a given set of parameters are returns an estimated time for this action in seconds. The script generator UI can then add these up for each row and display the total.

@Tom-Willemsen
Copy link
Contributor Author

+1 emu scientists.

@Tom-Willemsen Tom-Willemsen added the re-requested Issue that has been requested again by a user. label Jan 20, 2020
@kjwoodsISIS
Copy link
Contributor

+1 all scientists

@Tom-Willemsen
Copy link
Contributor Author

Thoughts from scientists at training session: it is useful to see the expected time for a particular row as well as a total. Perhaps we can add an extra column, like we have for validity which shows the estimated time for an individual row, as well as a "grand total" somewhere.

It would be useful to be able to access all of the rows in some way in the time estimation function, so that scientists can make the estimated time dependent on previous rows (this is important where ramps of temperature/field etc can take a long time).

@kjwoodsISIS kjwoodsISIS added bucket proposals that didn't make into the sprint and removed proposal labels Feb 7, 2020
@JamesKingWork
Copy link
Contributor

Should include squish tests

@DominicOram
Copy link
Contributor

+1 from MARI

@kjwoodsISIS kjwoodsISIS added bucket proposals that didn't make into the sprint and removed bucket proposals that didn't make into the sprint labels Apr 2, 2020
@mr-field mr-field self-assigned this Apr 27, 2020
@mr-field mr-field removed the proposal label Apr 27, 2020
@FreddieAkeroyd FreddieAkeroyd added in progress and removed bucket proposals that didn't make into the sprint labels Apr 27, 2020
@FreddieAkeroyd FreddieAkeroyd added this to the SPRINT_2020_04_02 milestone Apr 27, 2020
@DominicOram
Copy link
Contributor

With @mr-field not here someone else should pick up this rework

@RaiBishal
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 fixed re-requested Issue that has been requested again by a user. rework training
Projects
None yet
Development

No branches or pull requests

8 participants