Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflectometry: Zero motors via beamline parameters #4131

Closed
1 task done
ThomasLohnert opened this issue Mar 15, 2019 · 1 comment
Closed
1 task done

Reflectometry: Zero motors via beamline parameters #4131

ThomasLohnert opened this issue Mar 15, 2019 · 1 comment
Assignees

Comments

@ThomasLohnert
Copy link
Contributor

ThomasLohnert commented Mar 15, 2019

For alignment of a reflectometry beamline, users should be able to redefine the zero position on a motor via the top-level beamline parameters (e.g. writing the new zero position to a PARAM:<name>:SETZEROAT PV). Unlike zeroing it at the motor level directly, this allows taking engineering corrections into account.
Therefore if I am at the zero position when I redfine the position my readback will instantly read back 0.

Requires:

Acceptance Criteria

  1. Setting an offset parameter changes the sp and sp:rbv by the value given
  2. I can zero a beam offset parameter. Works for:
    1. For detector offset
    2. For sample height offset
    3. For slit height offset (this means zeroing both jaw blades to correct place)
  3. I can set a slit gap parameter zero (both blades are set)
  4. I can set an angle offset parameter to zero
  5. Close IOC Test Framework: Launch without running tests #4499
  6. Log line must be printed to show definition from and to

Implementation Detail

  1. Allow the motor to set zero so it is available to all motors. This should be a sequence record. With a button which does it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants