Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflectometry: Engineering Corrections #3541

Closed
ThomasLohnert opened this issue Sep 14, 2018 · 4 comments
Closed

Reflectometry: Engineering Corrections #3541

ThomasLohnert opened this issue Sep 14, 2018 · 4 comments
Assignees
@John-Holt-Tessella
Labels
fixed rework
Milestone
SPRINT_2019_08_15

Comments

@ThomasLohnert
Copy link
Contributor

ThomasLohnert commented Sep 14, 2018 •
edited
Loading

As a user of reflectometers, I would like to be able to apply arbitary offsets at both the beamline parameter and IOC axis level, in order to account for slight discrepancies between the calculated and actual beam position (e.g. due to engineering errors).

https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Reflectometry-Composite-Driving-Layer#engineering-offset
@kjwoodsISIS kjwoodsISIS mentioned this issue Jan 4, 2019
Closed
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2019_01_31 milestone Jan 31, 2019
@John-Holt-Tessella John-Holt-Tessella self-assigned this Feb 28, 2019
@ThomasLohnert
Copy link
Contributor Author

Not needed for blind test end of March.

@ThomasLohnert ThomasLohnert mentioned this issue Mar 15, 2019
Closed
1 task
@ThomasLohnert ThomasLohnert changed the title Reflectometry: Offsets Reflectometry: Engineering Corrections Mar 21, 2019
@kjwoodsISIS
Copy link
Contributor

Return to Backlog (Sprint Planning 25-04-2019 decision).
Re-consider with all reflectometry tickets

@kjwoodsISIS kjwoodsISIS removed this from the SPRINT_2019_03_28 milestone Apr 25, 2019
@kjwoodsISIS kjwoodsISIS removed the ready label Apr 25, 2019
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2019_05_16 milestone May 16, 2019
@kjwoodsISIS kjwoodsISIS added 2 and removed 3 labels Jul 18, 2019
@ThomasLohnert ThomasLohnert added ready and removed review labels Aug 8, 2019
@Tom-Willemsen Tom-Willemsen added 0.5 and removed 2 labels Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@John-Holt-Tessella John-Holt-Tessella

Labels
fixed rework
Projects
None yet
Milestone
SPRINT_2019_08_15
Development

No branches or pull requests
4 participants
@kjwoodsISIS @John-Holt-Tessella @ThomasLohnert @Tom-Willemsen