Ticket 6774 pearlpc cell and pump pressure #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate thread polling, replaced with update on checking status which happens frequently anyway
…ons. Fixed functionality for: retract/reset logic, application rate, retract complete logic, increase/decrease pressure and ready LEDs, added 'nominal pressure out of range' logic
…. Replaced those with backdoor access functions. Tests adjusted accordingly to those changes
…sing/decreasing LED indicators
2 tasks
* change some PV names for clarity * use DISP rather than changing DRVH/DRVL
|
Looking good - have just made a fee updates to the original PV names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISISComputingGroup/IBEX#6774