Ticket6100

[NikolaRoev]

Description of work

This controller can be used for both DISC and FERMI choppers.

To test

ISISComputingGroup/IBEX#6100

Acceptance criteria

List the acceptance criteria for the PR

---

Code Review

• A copy of the manual has been placed on the shared drive
• Pertitent information has been stored in the wiki
• Does the IOC conform to IBEX standards?
  • PV naming.
  • Disable records
  • Record simulation
  • Finishing touches
• If an OPI has been modified, does it conform to the style guidelines?
• Do the IOC and support module conform to the new build guidelines
• Have the changes been recorded appropriately in a PR for release notes?
• Is the device's flow control setting correct? For most devices flow control should be OFF.

Functional Tests

• IOC responds correctly in:
  • Devsim mode
  • Recsim mode
  • Real device, if available
• Supplementary IOCs (..._0n where n>1) run correctly
• Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

• Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
• Reviewer has merged the associated PR for the release notes

[pheest]

The IOC has the RELEASE file with include $(TOP)/../../../configure/MASTER_RELEASE et.al.
This differs from the recommendation of https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Reducing-Build-Dependencies.

[NikolaRoev]

The change done in this pull request is only concerned with the UI. As the description can be used to search for a specific IOC. make configuration issues feel very out of scope for this ticket.

[pheest]

Fair enough, I would tend to agree.

…

________________________________ From: Nikola Roev ***@***.***> Sent: Monday, December 19, 2022 5:06 PM To: ISISComputingGroup/EPICS-ioc ***@***.***> Cc: Heesterman, Peter (Capgemini,RAL,ISIS) ***@***.***>; Comment ***@***.***> Subject: Re: [ISISComputingGroup/EPICS-ioc] Ticket6100 (PR #758) The change done in this pull request is only concerned with the UI. As the description can be used to search for a specific IOC. make configuration issues feel very out of scope for this ticket. — Reply to this email directly, view it on GitHub<#758 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD6SZN3N6ZSTRG2P6XSOEL3WOCI2NANCNFSM6AAAAAAS6UIIGM>. You are receiving this because you commented.Message ID: ***@***.***> This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.