Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket3897 disable mode save #265

Merged
merged 8 commits into from
Mar 13, 2020
Merged

Conversation

John-Holt-Tessella
Copy link
Contributor

Description of work

Save incoming beams for all componetns on enter disable mode
Restore on init

To test

ISISComputingGroup/IBEX#3897

Acceptance criteria

See ticket


Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

not changing

Extend autosave to include a conversion method
Fix tests for use of conversion
@aaron-long
Copy link
Member

aaron-long commented Jan 17, 2020

Please try the following:

  1. Zero beamline in Polarised NR
  2. Enter Disabled mode and change theta to 0.1
  3. Restart the REFL IOC
  4. Check Theta RBV -> it will state 0.1
  5. Move theta to 0.0 -> RBV will instantly update to 0.0

Also:

  1. Zero beamline in Polarised NR
  2. Enter Disabled mode and change theta to 0.1
  3. Restart the REFL IOC
  4. Attempt to change alignment for PDangle, PDoffset etc (relating to theta) -> The current position will move as the value for the defined position + some existing offset from the saved beam

@ThomasLohnert ThomasLohnert merged commit a393257 into master Mar 13, 2020
@John-Holt-Tessella John-Holt-Tessella deleted the Ticket3897_disable_mode_save branch June 10, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants