Ticket7350 #1
Merged
Ticket7350 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 14, 2022 11:38
LilithCole
requested changes
Oct 21, 2022
Comment on lines
+21
to
+30
| record(mbbi, "$(P)JMP:MODE") | ||
| { | ||
| field(INP, "$(PVPREFIX)TJMPER_$(TJMPER_IOC_ID):MODE CP MSS") | ||
| field(SCAN, "Passive") | ||
| field(DTYP, "Soft Channel") | ||
| field(ZRST, "All out") # All home | ||
| field(ONST, "PLT1 and SMPL engaged") # Engage Plate 1 and sample | ||
| field(TWST, "PLT2 and SMPL engaged") # Engage Plate 2 and sample | ||
| info(interest, "HIGH") | ||
| } |
There was a problem hiding this comment.
When does this record actually process? SCAN is Passive but I don't see anything linking to it
There was a problem hiding this comment.
Doesn't using CP in the INP field mean that the record is processed when the input updates?
Comment on lines
+43
to
+51
| record(ai, "$(P)SAMPLE:TEMP") | ||
| { | ||
| field(INP, "$(PVPREFIX)$(SAMPLE_TEMP_READBACK):TEMP CP MSS") | ||
| field(DESC, "Value for the sample temperature") | ||
| field(SCAN, "Passive") | ||
| field(DTYP, "Soft Channel") | ||
| info(interest, "HIGH") | ||
| info(archive, "VAL") | ||
| } |
There was a problem hiding this comment.
Likewise for this input
LilithCole
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISISComputingGroup/IBEX#7350