Ticket6044 #1
Merged
Ticket6044 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISISComputingGroup/IBEX#6044
Both the manual and the vendor drivers seem to be wrong on the terminating characters for the protocol file. The manual says new line <10d>, while the vendor drivers use both carriage return and new line. The correct terminator is just carriage return <09d>.
Also had to add a read timeout that was missing in the vendor driver. I am not sure if this is due to the specific device I used for my test. Even if it is, it should not be an issue. 1000ms seem to be working okay, but it is something to have in mind when PEARL is migrated.
Note to reviewer:
Device is set up in the office. Try not to keep the output state to
Controlfor too long as the device immediately starts to alarm.*Return device to Christopher Ridley from PEARL if I am no longer around.