Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket6777 #593

Merged
merged 17 commits into from
Aug 21, 2023
Merged

Ticket6777 #593

merged 17 commits into from
Aug 21, 2023

Conversation

boeuf-codes
Copy link
Contributor

Ticket #6777

  • Created new module for needle valve tests
  • Added tests for various aspects of new IOC functionality
    • (mainly focusing on access rights regarding manager mode and/or .DISP sets)
  • Edited common eurotherm tests so will behave correctly regarding NEEDLE_VALVE macro and write permissions for TEMP:SP

Copy link
Contributor

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running eurotherm_eibisynch:

TypeError: Can't instantiate abstract class EurothermTests with abstract method _get_temperature_setter_wrapper

Needs a definition of the abstract method.

Also:

Running tests...
----------------------------------------------------------------------
..................F................................................
======================================================================
FAIL [43.223s]: test_WHEN_disconnected_THEN_in_alarm_1_TEMP_SP_RBV (tests.eurotherm_modbus_needlevalve.EurothermModbusNeedleValveTests.test_WHEN_disconnected_THEN_in_alarm_1_TEMP_SP_RBV)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\INSTRU~2\Apps\Python3\Lib\site-packages\parameterized\parameterized.py", line 620, in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Instrument\Apps\EPICS\support\IocTestFramework\master\common_tests\eurotherm.py", line 251, in test_WHEN_disconnected_THEN_in_alarm
    self.ca.assert_that_pv_alarm_is(record, ChannelAccess.Alarms.INVALID, timeout=30)
  File "c:\Instrument\Apps\EPICS\support\IocTestFramework\master\utils\channel_access.py", line 531, in assert_that_pv_alarm_is
    return self.assert_that_pv_is("{}.SEVR".format(pv_no_field), alarm, timeout=timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Instrument\Apps\EPICS\support\IocTestFramework\master\utils\channel_access.py", line 271, in assert_that_pv_is
    return self.assert_that_pv_value_causes_func_to_return_true(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Instrument\Apps\EPICS\support\IocTestFramework\master\utils\channel_access.py", line 250, in assert_that_pv_value_causes_func_to_return_true
    raise AssertionError(err)
AssertionError: Exception date time: 2023-04-24 16:11:21.458690
Expected PV, 'TE:NDLT1205:EUROTHRM_01:A01:TEMP:SP:RBV.SEVR' to have value 'INVALID' (type: 'str').
Final PV value was 'NO_ALARM' (type: 'str')

----------------------------------------------------------------------

@zsoltkebel zsoltkebel merged commit 917d66b into master Aug 21, 2023
@zsoltkebel zsoltkebel deleted the Ticket6777 branch August 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants