Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IOC test framework device disconnection tests & add README documentation #558

Merged
merged 41 commits into from
Sep 20, 2022
Merged

Refactor IOC test framework device disconnection tests & add README documentation #558

merged 41 commits into from
Sep 20, 2022

Conversation

boeuf-codes
Copy link
Contributor

@boeuf-codes boeuf-codes commented Aug 17, 2022 •
edited
Loading

Ticket: ISISComputingGroup/IBEX#7266
Refactoring all test modules which contain the common behaviour as described in the ticket.

  • Added documentation in IOC Test Framework README for use of new util fn
  • Added a emulator util function to generalise common device disconnection behaviour
  • Used new emulator util function instead of old logic
  • Added in asserts/before main assertions for robustness
  • Occasionally fixed some tests which threw errors as a result of the above

@boeuf-codes
Add utility fn to simulate device disconnection
b662fd3
@boeuf-codes
Refactor lakeshore372 test with new util fn
dd79b7f
@boeuf-codes
Refactor common_tests/kepco test with new util fn
8907cc7
@boeuf-codes
Refactor chtobisr test with new util fn
dd1c8c7
@boeuf-codes
Refactor flipprps test with new util fn
001f4ee
@boeuf-codes
Add some extra checking to changed tests
00a60d1
@boeuf-codes
Refactor heliox test with new util fn
87516c5
@boeuf-codes
Refactor lksh218 test with new util fn
5ecc622
@boeuf-codes
Refactor mcfrf test with new util fn
28a924a
@boeuf-codes
Refactor another test in heliox
9e9f7ea
@boeuf-codes
Refactor mezflipr_v2 test with new util fn
2fd9b07
@boeuf-codes
Refactor ag33220a test with new util fn
8517407
@boeuf-codes
Refactor amint2l test with new util fn
c3d2e8c
@boeuf-codes
Refactor another test in flipprps
bde6a0e
@boeuf-codes
Refactor cybaman test with new util fn
9b3d45d
@boeuf-codes
Add extra checks for refactored test in flipprps
19e2294
@boeuf-codes
Refactor keylkg test with new util fn
ab35941
@boeuf-codes
Refactor knr1050 test with new util fn
294c253
@boeuf-codes
Refactor smrtmon test with new util fn
4431378
@boeuf-codes
Forgot to remove old line of code
5f12350
@boeuf-codes
Refactor eurotherm test with new util fn
4614b63
@boeuf-codes
Refactor mercuryitc test with new util fn
85154e3
@boeuf-codes
Refactor dma4500m test with util fn and tidied
d40dbe1
@boeuf-codes
Refactor numerous tests with new util fn
94dea84
@boeuf-codes
Refactor numerous tests with new util fn
e536a8a
@boeuf-codes
Update util fn params to take different properties
efd7059
@boeuf-codes
Refactor superlogics test with new util fn
3ed8e3c
@boeuf-codes
Fix incorrect refactored logic
e2f220f
@boeuf-codes
Refactor danfysik test & delete redundant property
e5b565e
@boeuf-codes
Refactor edwardstic test with new util fn
8cf9d42
@boeuf-codes boeuf-codes changed the title Refactor all modules which test device disconnection behaviour Refactor all IOC test framework modules which test device disconnection behaviour Aug 17, 2022
@boeuf-codes boeuf-codes mentioned this pull request Aug 17, 2022
Closed
4 tasks
@boeuf-codes boeuf-codes changed the title Refactor all IOC test framework modules which test device disconnection behaviour Refactor IOC test framework device disconnection tests & add documentation Aug 17, 2022
@boeuf-codes boeuf-codes changed the title Refactor IOC test framework device disconnection tests & add documentation Refactor IOC test framework device disconnection tests & add README documentation Aug 17, 2022
JackEAllen
JackEAllen requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big one! Thanks for tackling it! 👍
Just left minor comments here and there, feel free to challenge me on any or them 🙂
I'll place this into rework for the time being until I get your opinion on my comments.

README.md Outdated Show resolved Hide resolved
common_tests/danfysik.py Show resolved Hide resolved
common_tests/danfysik.py Outdated Show resolved Hide resolved
common_tests/danfysik.py Outdated Show resolved Hide resolved
common_tests/danfysik.py Outdated Show resolved Hide resolved
tests/sm300.py Outdated Show resolved Hide resolved
tests/smrtmon.py Show resolved Hide resolved
tests/superlogics.py Outdated Show resolved Hide resolved
tests/superlogics.py Outdated Show resolved Hide resolved
tests/superlogics.py Outdated Show resolved Hide resolved
@boeuf-codes boeuf-codes requested a review from JackEAllen August 25, 2022 08:34
JackEAllen
JackEAllen approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@JackEAllen JackEAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JackEAllen JackEAllen merged commit 97478e6 into master Sep 20, 2022
@JackEAllen JackEAllen deleted the Ticket_7266 branch September 20, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackEAllen JackEAllen JackEAllen approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boeuf-codes @JackEAllen