Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use just LF for in terminator #173

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

FreddieAkeroyd
Copy link
Member

Copy link
Contributor

@rerpha rerpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we have this wrong for all kepcos? can't remember if they were used elsewhere other than the zf system?
edit: jsut remembered the HTS magnet did as well?

@FreddieAkeroyd
Copy link
Member Author

The kepco allows either CR or LF as the terminator for data sent to it, I changed the kepco protocol to send just LF (to save one character - also with CR LF the kepco starts processing at CR and i wasn't sure what would happen to the LF in that case). So this is just to make the emulator consistent with the corresponding PR that changes the kepco proto file. If anything other than the kepco IOC uses the kepco lewis emulator, then it may need changing too.

@rerpha rerpha merged commit 52969d3 into master May 28, 2024
@rerpha rerpha deleted the Ticket7778_zerofield_speedup branch May 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants