Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom file update to build XOAI-5.0.0 #9339 #9354

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

landreev
Copy link
Contributor

@landreev landreev commented Feb 1, 2023

What this PR does / why we need it:

As described in the linked issue, switching the application to the long-awaited final version of the XOAI v.5.0.0 that has just been released.

Which issue(s) this PR closes:

Closes #9339

Special notes for your reviewer:

This uses the final, mature version of XOAI 5.0.0. It contains the latest changes, that were added to accommodate the PR #9310. Those were tested as part of the QA on that PR (built with the final release candidate version, essentially the same jars but packaged as dev. snapshots. The original plan was to wait for the 5.0.0 to be packaged before merging it, but then we merged it anyway; kind of by accident, but in retrospect, it would look bad for that PR to sit in QA all this time).

The XOAI release in question is the mature version, and the culmination of all the work done to improve, update and modernize the library since it was forked off DSpace/xoai and moved into its new home at https://github.com/gdcc/xoai. Massive credit goes to @poikilotherm for making it happen and all the work he's done there.

Suggestions on how to test this:
Functionality-wise, almost everything in this PR has gone through our QA process already. So it may only need a quick glance, confirming that nothing is visibly broken and the integration tests are passing.
The only small change/improvement you will notice is the treatment of yyyy-mm-dd dates (the thing you noticed during QA of #9316)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage: 19.936%. Remained the same when pulling 3cb7707 on 9339-xoai-5.0.0-release into 839065a on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question.

@kcondon kcondon self-assigned this Feb 1, 2023
@kcondon kcondon merged commit dd46319 into develop Feb 1, 2023
@kcondon kcondon deleted the 9339-xoai-5.0.0-release branch February 1, 2023 21:52
@poikilotherm
Copy link
Contributor

Thanks for bearing with me! Glad we worked it all out.

@pdurbin pdurbin added this to the 5.13 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Update Dataverse pom file to build with the 5.0.0 release of XOAI library
6 participants