IQSS/8337_add metadatalanguage to export/import/migrate #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sent - use default not allowed - throw exception to return bad request
…adatalanguage_in_import/migrate
…adatalanguage_in_import/migrate
…adatalanguage_in_import/migrate
landreev
reviewed
Mar 14, 2022
| String expectedString = getData(response.getBody().asString()); | ||
|
|
||
| // Delete the dataset via native API | ||
| Response deleteDatasetResponse = UtilIT.deleteDatasetViaNativeApi(datasetId, apiToken); | ||
| deleteDatasetResponse.prettyPrint(); | ||
| assertEquals(200, deleteDatasetResponse.getStatusCode()); | ||
|
|
||
|
|
||
| logger.info("SENDING to reCreate Dataset: " + expectedString); |
There was a problem hiding this comment.
I'm going to assume this info log message was left here on purpose.
There was a problem hiding this comment.
~yes - we seem to have many tests that write useful intermediate results to the log (and seeing the exact json-ld sent to this API is useful). That said, nominally this and others could be changed to fine if we're concerned about the size of the IT test logs but we might also then want an easy way to up the log level when IT tests run.
…adatalanguage_in_import/migrate
can't send a metadataLanguage when the :MetadataLanguage setting is not set When it is, value must match parent, or if parent allows choice, be one of the allowed values per the setting.
|
Retesting:
|
qqmyers
commented
Apr 11, 2022
src/main/java/edu/harvard/iq/dataverse/api/imports/ImportDDIServiceBean.java
Outdated
Show resolved
Hide resolved
|
Thanks, @qqmyers ! |
…adatalanguage_in_import/migrate
qqmyers
force-pushed
the
IQSS/8337-handle_metadatalanguage_in_import/migrate
branch
from
9f651c0 to
67de235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR adds support for the new metadatalanguage value to the OAI_ORE export, and the json import/json-ld migrate API calls. This makes the metadata language used for the dataset visible in one more export and allows sending that value in when importing /migrating from prior exports/other systems.
Which issue(s) this PR closes:
Closes #8337
Special notes for your reviewer: FWIW: Since the metadatalanguage setting constrains which languages are allowed, the import/migrate api calls return a Bad Request error if you send one that isn't allowed. (Also assumes the default if you don't send one.)
Suggestions on how to test this: Configure with metadata languages and verify that the OAI-ORE export contains an https://schema.org/inLanguage value. The import and migrate APIs can also be tested by adding this value. (I'll look at the guide examples - this is optional so I don't want to add it to all examples but I can see about showing it somewhere.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here: export and api effects only. (FWIW: This is one of several updates to the OAI_ORE that will be happening - DataCommons is making several more so we may have an overall release note on the package of changes.)
Is there a release notes update needed for this change?:
Additional documentation: