-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5886 link harvested datasets via api #6935
Conversation
@sekmiller I have some questions when you have a minute:
|
Right, the issue wasn't unpublished, harvested (which can't exist), but (some) harvested datasets being identified as unpublished, possibly because they were missing a publication date in the db. |
@scolapasta Do you have a known test case? Also, what about the issue it purports to close with the JSF errors? |
JSF issue was just a type - 5586 instead of 5886. (I just fixed it for @sekmiller in the description) |
as for test cases, here is a search results of four harvested datasets in production that could not be linked: (can't link to dataset pages of course, because they don't have any. - here are there dbids for the API: 3822842, 3724321, 3767398, 3767393 ) |
@scolapasta Thanks, just found that out from Julian as well. |
@sekmiller This works now except for the case where the dataset is unpublished, it shows an incomplete error: {"status":"ERROR"} rather than {"status":"ERROR","message":"Can't link a dataset that has not been published"} Update: this was due to languages being enabled and the lang bundle not yet having the new key. When we use the default bundle, it works as expected. |
What this PR does / why we need it:
Allows a user to link a harvested dataset via the api. Previously there was a test that required that the dataset be published before it could be linked. This expands the test to allow datasets that haven't been published but are harvested to be linked
Which issue(s) this PR closes:
Closes #5886
Special notes for your reviewer:
I wasn't able to come up with a way to test this in the integration test. Any suggestions here would be welcome. (I tested by manually giving an unpublished dataset a dummy harvesting client id)
Suggestions on how to test this:
Does this PR introduce a user interface change?:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
None