-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4260 jakarta #6818
4260 jakarta #6818
Conversation
See also https://www.primefaces.org/primefaces-6-2-roadmap and primefaces/primefaces#3385 Removing this completely unused dependency.
Thanks @poikilotherm for the PR. @scolapasta going to assign to you for thoughts. With Draft PRs I don't know if there's something special we should handle process-wise, as they are specifically designed not to move forward to QA. Maybe in the template we should include a different field for what the person is expecting to get out of the review of a Draft PR... are there specific questions that need answering? I guess this would go back to Community Dev once CR feedback is added? Happy to talk if it's easier... |
I made this a draft to create a base for discussion. There might be things missing, like the release note. And maybe some proposed changes are not what you folks want... |
Should I refactor the three occurences of deprecated Beans, too? With JSF 2.3, a few beans from Faces have been deprecated, see https://javaserverfaces.github.io/docs/2.3/managed-bean-javadocs/deprecated-list.html |
@poikilotherm I approved before I saw the above comment; yes go ahead and let's refactor those now. |
Here we go, c0d24b0 was an easy one. Replaced the deprecated |
@poikilotherm so no more expected changes on your end? I'm ready to move to QA if true. |
There is more, but beyond scope for this issue. 😉 Go @scolapasta go 😄 |
@poikilotherm Issues found so far:
|
@poikilotherm This was fixed in a PR I added, so a refresh should solve this. |
We especially want to pick up the bug fix in pull request IQSS#6828.
What this PR does / why we need it:
When moving to Payara 5, we should move to Jakarta EE 8 (which is technically identical to Java EE 8). This is also unlocking new features like JSON-B, needed for #6694.
Which issue(s) this PR closes:
Closes #4260
Relates to #6230
Special notes for your reviewer:
I moved some dependencies around, too. Will further cleanup messy deps list when working on #6698. (Please note that I didn't move the GF JSON lib, this will change when with #6694.)
Suggestions on how to test this:
Compile and both unit and API tests should not fail.
We should test the usual happy pathes.
[added by @scolapasta: let's ket this be the issue that closes #6230, when ready to do final Payara testing, let's make sure this is merged with dev and then test this branch on Payara (other branches related to this work have been made so they also work on gf4; this one may not work*)]
(*) it might be interesting to try it on gf4, but that is not necessary
Does this PR introduce a user interface change?:
Nope.
Is there a release notes update needed for this change?:
Jakarta is wht cool kids use these days for EE development. We should add sth. to spread the word we are part of the cool gang and that devs should now start to use new standardized APIs.
Additional documentation:
Nothing so far.