4051 download all files #4363
Merged
4051 download all files #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
requested changes
Dec 6, 2017
| public void toggleSelectedFiles(){ | ||
| //method for when user clicks (de-)select all files | ||
| public void toggleAllSelected(){ | ||
| System.out.print("in toggle all"); |
There was a problem hiding this comment.
Can you please remove this System.out.print or convert it to logger.fine if it might be valuable when debugging in production?
pdurbin
approved these changes
Dec 6, 2017
| public void toggleSelectedFiles(){ | ||
| //method for when user clicks (de-)select all files | ||
| public void toggleAllSelected(){ | ||
| this.selectAllFiles = !this.selectAllFiles; |
There was a problem hiding this comment.
At first blush this.selectAllFiles = !this.selectAllFiles was confusing to me but I understand that this is a toggle. Clicking means "reverse the state of this thing". We could add a comment to clarify this.
…ines of metadata
…ividual row select/unselect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist