Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScholarsPortal Internationlization_4.5 #3327

Closed
wants to merge 43 commits into from
Closed

ScholarsPortal Internationlization_4.5 #3327

wants to merge 43 commits into from

Conversation

JayanthyChengan
Copy link
Contributor

@JayanthyChengan JayanthyChengan commented Sep 2, 2016

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

List and link to the issues in this Pull Request.

  • [#### + Title HERE]

2. Pull Request Checklist

  • Functionality completed as described in FRD
  • Dependencies, risks, assumptions in FRD addressed
  • Unit tests completed
  • Deployment requirements identified (e.g., SQL scripts, indexing)
  • Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Connects to #209.

JayanthyChengan and others added 30 commits September 17, 2015 15:28
…ata.

Bug in hack to translate metadata fields
Conflicts:
	src/main/webapp/dataverse_template.xhtml
	src/main/webapp/metadataFragment.xhtml
	src/main/webapp/resources/iqbs/messages.xhtml
	src/main/webapp/search-include-fragment.xhtml
	src/test/java/edu/harvard/iq/dataverse/util/BundleUtilTest.java
language-toggle-branch

Conflicts:
	scripts/api/data/metadatablocks/astrophysics.tsv
	scripts/api/data/metadatablocks/biomedical.tsv
	scripts/api/data/metadatablocks/citation.tsv
	scripts/api/data/metadatablocks/customGSD.tsv
	scripts/api/data/metadatablocks/geospatial.tsv
	scripts/api/data/metadatablocks/journals.tsv
	scripts/api/data/metadatablocks/social_science.tsv
	scripts/installer/install
	src/main/java/edu/harvard/iq/dataverse/LoginPage.java
	src/main/java/edu/harvard/iq/dataverse/authorization/providers/builtin/BuiltinAuthenticationProvider.java
	src/main/webapp/dataset.xhtml
	src/main/webapp/loginpage.xhtml
	src/main/webapp/permissions-manage.xhtml
	src/main/webapp/resources/iqbs/messages.xhtml
	src/test/java/edu/harvard/iq/dataverse/util/BundleUtilTest.java
into SP_Internationlization_4.5-fix-versionno

# Conflicts:
#	scripts/api/data/metadatablocks/citation.tsv
#	src/main/java/Bundle.properties
#	src/main/java/edu/harvard/iq/dataverse/EMailValidator.java
#	src/main/java/edu/harvard/iq/dataverse/ManageFilePermissionsPage.java
#	src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java
#	src/main/webapp/apitoken.xhtml
#	src/main/webapp/dataverse_template.xhtml
#	src/main/webapp/dataverseuser.xhtml
@JayanthyChengan JayanthyChengan changed the title Sp internationlization 4.5 fix versionno ScholarsPortal Internationlization_4.5 Sep 2, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 7.958% when pulling 23698d7 on JayanthyChengan:SP_Internationlization_4.5-fix-versionno into dc58ae1 on IQSS:develop.

….com:JayanthyChengan/dataverse.git into SP_Internationlization_4.5-fix-versionno
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 7.958% when pulling fffb621 on JayanthyChengan:SP_Internationlization_4.5-fix-versionno into dc58ae1 on IQSS:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 7.958% when pulling 3665bf0 on JayanthyChengan:SP_Internationlization_4.5-fix-versionno into dc58ae1 on IQSS:develop.

@mheppler
Copy link
Contributor

@JayanthyChengan when trying to build your branch, I received some error msg regarding a missing column.

Please provide the necessary SQL update script in the "dataverse/scripts/database/upgrades/" directory. (See an example of such an update script in commit b703e27.)

Info: Loading application [dataverse] at [/] Warning: Context path from ServletContext: differs from path from bundle: / Warning: Local Exception Stack: Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException Internal Exception: org.postgresql.util.PSQLException: ERROR: column "frenchdescription" does not exist Position: 161 Error Code: 0 Call: SELECT ID, ADVANCEDSEARCHFIELDTYPE, ALLOWCONTROLLEDVOCABULARY, ALLOWMULTIPLES, description, DISPLAYFORMAT, DISPLAYONCREATE, DISPLAYORDER, FACETABLE, FIELDTYPE, frenchdescription, frenchtitle, name, REQUIRED, title, WATERMARK, METADATABLOCK_ID, PARENTDATASETFIELDTYPE_ID FROM DATASETFIELDTYPE ORDER BY ID Query: ReadAllQuery(referenceClass=DatasetFieldType sql="SELECT ID, ADVANCEDSEARCHFIELDTYPE, ALLOWCONTROLLEDVOCABULARY, ALLOWMULTIPLES, description, DISPLAYFORMAT, DISPLAYONCREATE, DISPLAYORDER, FACETABLE, FIELDTYPE, frenchdescription, frenchtitle, name, REQUIRED, title, WATERMARK, METADATABLOCK_ID, PARENTDATASETFIELDTYPE_ID FROM DATASETFIELDTYPE ORDER BY ID") at org.eclipse.persistence.exceptions.DatabaseException.sqlException(DatabaseException.java:340) at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.basicExecuteCall(DatabaseAccessor.java:682) at org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeCall(DatabaseAccessor.java:558) at org.eclipse.persistence.internal.sessions.AbstractSession.basicExecuteCall(AbstractSession.java:2002)

SP_Internationlization_4.5-fix-versionno

Conflicts:
	src/main/java/edu/harvard/iq/dataverse/ManageFilePermissionsPage.java
	src/main/java/edu/harvard/iq/dataverse/ManagePermissionsPage.java
	src/main/webapp/dataverse_template.xhtml
	src/main/webapp/roles-assign.xhtml
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 8.607% when pulling ebba934 on JayanthyChengan:SP_Internationlization_4.5-fix-versionno into efc83c6 on IQSS:develop.

@JayanthyChengan
Copy link
Contributor Author

Step 1:

Run the database update script.
psql -U -d -f upgrade_v4.5_to_SPInternationlization.sql

Step 2:

  • place the tsv file on the web server.
  • run these api commands to update the metadata block:

curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @citation.tsv -H "Content-type: text/tab-separated-values"
curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @geospatial.tsv -H "Content-type: text/tab-separated-values"
curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @social_science.tsv -H "Content-type: text/tab-separated-values"
curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @astrophysics.tsv -H "Content-type: text/tab-separated-values"
curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @biomedical.tsv -H "Content-type: text/tab-separated-values"
curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @journals.tsv -H "Content-type: text/tab-separated-values"

@pdurbin
Copy link
Member

pdurbin commented Nov 8, 2017

@JayanthyChengan thanks for participating in the community call yesterday: https://groups.google.com/d/msg/dataverse-community/d7BnFiRA3_I/O6cYqSBfCAAJ

@pdurbin
Copy link
Member

pdurbin commented Mar 21, 2018

This pull request is so old and is so far behind the "develop" branch that there are many merge conflicts. I'm closing it. As we indicated in the 2017-11-07 Dataverse Community Call notes at https://groups.google.com/d/msg/dataverse-community/d7BnFiRA3_I/O6cYqSBfCAAJ IQSS doesn't have the capacity to lead on internationalization so we are looking to the community to help. The "Dev Efforts by the Dataverse Community" spreadsheet at https://docs.google.com/spreadsheets/d/1pl9U0_CtWQ3oz6ZllvSHeyB0EG1M_vZEC_aZ7hREnhE/edit?usp=sharing is a good place to see what the community is up to. As of this writing you can entries for "internationalization" and "multilingual" and note that some of the cells have comments. For more context on that spreadsheet, see the " Which GitHub issues are being worked on by the Dataverse community?" at https://groups.google.com/d/msg/dataverse-community/X2diSWYll0w/ikp1TGcfBgAJ

@pdurbin pdurbin closed this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants