Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates: When inherit from parent, does not indicate which is default. #850

Closed
kcondon opened this issue Aug 25, 2014 · 7 comments
Closed
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Aug 25, 2014

When inherit from parent, does not indicate which is default.

@eaquigley
Copy link
Contributor

default button doesn't appear when you inherit templates from a parent dataverse; still need an indicator that there is a default template set based off the parent dataverse. users can choose to change the default template from the one set at the parent dv that they've inherited.

@sekmiller
Copy link
Contributor

Fixed in recent check in (8/27 5:15)

@kcondon
Copy link
Contributor Author

kcondon commented Aug 28, 2014

This works as explained off ticket: if no local default set and include parent is checked, displays parent's default.

One minor issue is that if default changes at the parent level since dv initially created or include checked, default state not also updated. Had similar issue with new templates at one point. So maybe just read fresh each time or is that too costly?

@kcondon kcondon assigned sekmiller and unassigned kcondon Aug 28, 2014
@sekmiller
Copy link
Contributor

As discussed with Kevin, the logic for setting the default at the child level when "Include" is selected only gives the child the parent's default when the child's default is blank. Setting the child's default because the parent's default changed was not contemplated - seems like that could be an enhancement.

@kcondon
Copy link
Contributor Author

kcondon commented Sep 8, 2014

Tested on 9/8
This works if you have only 2 levels of dataverses: root and child. If you have a grandchild or deeper, it does not check the parents or anything between root and itself for whether there is a default.

@sekmiller
Copy link
Contributor

The issue was that the default template was not being wiped out if the default was inherited, but the user decided not to inherit. Fix available in next build

@kcondon
Copy link
Contributor Author

kcondon commented Sep 10, 2014

OK, retested and now works: check/uncheck/check inherit from parent with change of default in the middle is reflected in child default.

Closing

@kcondon kcondon closed this as completed Sep 10, 2014
eaquigley added a commit that referenced this issue Feb 8, 2016
updated text for this workflow to be more user friendly. Issue #2722
eaquigley added a commit that referenced this issue Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

3 participants