Internationalization - alert messages is not toggling with language selection

[JayanthyChengan]

The alert info/warning/success messages remains English , and doesn't toggle with Language selection .

[landreev]

harvesting clients page, with the fixes applied:

[landreev]

@scolapasta - if you're online, please take take a look and let me know what you think...

In addition to the above, I'm wondering if we should refactor things a little; specifically, I'm not sure we even need this new dedicated DataverseLocaleBean... As it is, it does 2 things:

• tracks the currently selected locale throughout the user's session. But does it need a bean of its own? - We already have a session-scoped bean: the actual session, DataverseSession. Any reason not to handle the locale setting there? (anything I'm missing?)

• the other part is the methods that are not specific to any individual sessions - useLocale() that decides if we need the language dropdown (all it does, it checks if there's more than 1 language configured in the settings) and the methods that populate it if so. I feel it would make more sense to move these into the SettingsWrapper.

Let me know.

[landreev]

Also - probably out of scope - what about all the text messages in the API responses; are we ok with them always being in the locale that is the default for the specific Dataverse installation? (i.e., the configured locale on the server running the application).

(one alternative would be to default to that, but then also try to honor the "Accept-Language" header in the HTTP request, if possible...)

[landreev]

(the current solution appears to be working well; I'll sleep on it over the weekend and make a PR before next week)

[landreev]

The code in the PR has been refactored as outlined above: the session-scoped bean DataverseLocaleBean has been removed; its functionality split between DataverseSession and SettingsWrapper.

[djbrooke]

Assigning to @matthew-a-dunlap because of his pre-volunteering in standup this morning :)

[scolapasta]

@landreev The only thought I had for not including on every xhtml would be to have every page bean extend from a base bean that had a default init method that does this and then calls a the page specific init method (renamed to _init or something else). Would still require making lots of changes now, but would be more maintainable if we had any other such changes.

Probably not worth the effort right now, but something to consider for the future.