-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization : UI toggle for language selection #4685
Comments
Thanks @JayanthyChengan for this (and for all the internationalization PRs!). We discussed this briefly in standup today, and since this is getting into UI/UX land, I'll tag @TaniaSchlatter. Can you let us know what you're thinking? |
@djbrooke : Thanks for involving Tania for UI design.
|
Hi @JayanthyChengan and @djbrooke, see the image attached for button appearance and placement. I suggest placement in the navbar using UL Dropdown, even if there are just two languages. Reference for the mockup is here: |
@djbrooke @scolapasta : To get the dropdown list of languages dynamically, planning to have a database table for languages and pull the values from it. So, we can use CURL commands to add new languages and fetch corresponding bundle.properties in the application. Let me know, if there is any other better approach to tackle this. To establish the locale into the web application, I will follow https://docs.oracle.com/javaee/6/tutorial/doc/bnaxw.html Please confirm with your thoughts. Thanks |
same additional input from google https://support.google.com/webmasters/answer/182192?hl=en |
@amberleahey @JayanthyChengan we missed this in the all the OR2018 and DCM excitement. We'll have the design team take a quick look and provide some feedback. |
Hi @amberleahey, the rationale for the suggested language toggle was concern about length and shifting placement of items in the navigation bar. Placing the toggle to the right of the other items would cause placement to shift with the varying length of user names. I liked that the suggested toggle was short, clear, and consistent in length. What are the SP team's concerns? Maybe asking what is preferable in the alternative examples is a better way to limit debate? :) Thanks for posting the google link. It has good a good summary of things to keep in mind. We will need to discuss with @mheppler and @scolapasta. |
@amberleahey @JayanthyChengan After reviewing the UI options with @TaniaSchlatter and discussing in a little more detail with a our visiting German developer, I have some recommendations -- and a mockup!
We're happy to discuss further and research other options. Let us know if you have any feedback. |
Makes sense, we were a bit worried about disruption in the nav bar, but this looks good! Thanks for the tips and mock-up. |
@JayanthyChengan I don't see any objections above and this is fine with me. |
|
Thanks @mheppler |
With the help of @scolapasta (java) and @pdurbin (git), I was able to get the language dropdown for the navbar converted over from a selectOneMenu form component, to a list of links, in the Bootstrap styling we had originally mocked up. I created a new branch, and pull request, and linked it to this issue. Will move it to Code Review now, so that @scolapasta can revisit some of the backing bean logic he helped "get working". I will also need to revisit some of the inline CSS I quickly added in order to get looking a lil more Bootstrappy. |
NOTE: This branch will most likely need to be updated with |
@JayanthyChengan, we're very interested to try this new switch languages functionality in DataverseEU project. At the moment we have Bundle.properties for French, German, Slovenian, Swedish, Ukrainian and Spanish languages, how can we connect to web interface to see all available languages there? |
@4tikhonov you should check out the new |
I'll post something about this upcoming DV release and community objectives around collecting additional languages and the maintenance of them (to the Google Group). Thanks @4tikhonov for those additional language files they will be great for testing. We don't have a public DV instance w/this code accessible at the moment, but we will work on that with the Harvard team. |
@4tikhonov here's a screenshot of how the language toggle looks on https://dev1.dataverse.org @amberleahey I'm looking forward to your write up! Thanks! |
Phil, looks great! Is it possible to get different languages on different subdomains/paths, for example, fr.dataverse.org or dataverse.org/fr for French? |
@4tikhonov no, I don't think so. If this is something you want or need, please open an issue for it. |
This is what we're implementing with running different containers for all languages. But if there is possibility to get it as a part of core functionality it would be great. |
Great, I have another question then about metadata schema: is it also already translated to French if you'll switch to it? |
Update from the community call today, many people require having Dataverse in a specific language locale e.g. EN-CA, FR-FR, etc., and to be able to differentiate this in the UI toggle. Can we revisit the design of the UI toggle to incorporate these country/locales codes? Someone mentioned using ISO country and language codes or some combination of plain language and code might be best. see: https://docs.oracle.com/cd/E13214_01/wli/docs92/xref/xqisocodes.html as example of codes to combine... |
@amberleahey we're always open to revisiting anything but can you please create a new GitHub issue for the language toggle? This closed issue represents the work that was done in pull request #4841 for the next version of Dataverse (the current version is 4.9.2). Thanks! |
Let's continue the conversation at #5046 (thanks for creating that issue, @amberleahey !). |
Have to figure out where to place the toggle button in the main page?
The text was updated successfully, but these errors were encountered: