Files: Ability to Replace a File Instead of Deleting

[eaquigley]

For the Provenance project, we need to determine how a user can replace a file instead of deleting the file and uploading a new one.

This relates to the backend structure (@scolapasta and @landreev) and what it looks like in the UI (@eaquigley and @mheppler)

---

• Make sure group check is activated before pull request!!

[djbrooke]

Notes from @raprasad from #3220

To support Provenance, we need to add versioning/replace functionality for DataFile objects.

Basics:

User may replace an existing dataset file with a new one:
via UI
via API
File versions are tied to dataset versions
Technical notes:

Internal storage:

DataFile will have two extra fields:
Root DataFile id
Previous DataFile id
DataFile id Root DataFile ID Previous DataFile ID
1 1 null
5 1 1
7 1 5
35 1 7

[djbrooke]

Mockups

[pdurbin]

I've been fixing bug here and there, especially for #1612 but as of yesterday morning when I merged the latest from develop into pull request #3579 I'm done messing with the branch. Since then @kcondon has been QA'ing it. I'm unassigning myself from this issue.

[kcondon]

Issues:
x1. On file landing page for replaced file, edit button still appears, including the replace option which is not possible. Choosing any option results in an error since there is no current version for this file.
x2. Replacing a file with a different type in the UI should give the user an opportunity to not do so by presenting a popup with the info of different types. Currently just replaces with a message.
x3. Minor wording issue in error response in API: Failed to add file the dataset.
x4. Force option in file replace api endpoint that allows replacing a file with a different type is not documented
x5. Opened as #3603 Cannot replace a shape file because it is a zip file. Spoke to Raman and he indicated as designed but needs to be made to work and recommends a separate ticket.
x6. API add/replace code ignores file size upload limit. Leonid knows something about this. Update: now checks file upload size but error is uninformative: status":"ERROR","message":"There was an error when trying to add the new file. Message now fixed, added file size limit info.
7. Download tracking/ Guestbook download file does not include file id so renaming/replacing files are not trackable through that info.
8. Replace (and edit) still appears for deleted files in older versions of datasets, throws errors and in some cases creates draft datasets.

[landreev]

6. API add/replace code ignores file size upload limit. Leonid knows something about this.

Ok, yes, I effectively disabled the size limit check in Raman's API upload/replace framework when I was merging his code in.
Just went ahead and fixed it; please re-test.