more tweaks per review of the PR (#8372)

IQSS · Jul 14, 2022 · dbf1309 · dbf1309
1 parent d1504be
commit dbf1309
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 12 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiItem.java b/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiItem.java
@@ -20,7 +20,7 @@
  * You can think of it as an XOAI Item wrapper around the
  * Dataverse OAIRecord entity.
  */
-public class DataverseXoaiItem implements Item {
+public final class DataverseXoaiItem implements Item {
 
     public DataverseXoaiItem(OAIRecord oaiRecord) {
         super();
@@ -29,7 +29,6 @@ public DataverseXoaiItem(OAIRecord oaiRecord) {
         if (!StringUtil.isEmpty(oaiRecord.getSetName())) {
             oaisets.add(new Set(oaiRecord.getSetName()));
         }
-        about = new ArrayList<>();
     }
 
     private OAIRecord oaiRecord;
@@ -53,13 +52,6 @@ public DataverseXoaiItem withDataset(Dataset dataset) {
         return this; 
     }
 
-    private List<About> about;
-
-    @Override
-    public List<About> getAbout() {
-        return about;
-    }
-
     private Metadata metadata;
 
     @Override

diff --git a/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiItemRepository.java b/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiItemRepository.java
@@ -43,7 +43,6 @@ public class DataverseXoaiItemRepository implements ItemRepository {
     private String serverUrl; 
 
     public DataverseXoaiItemRepository (OAIRecordServiceBean recordService, DatasetServiceBean datasetService, String serverUrl) {
-        super();
         this.recordService = recordService;
         this.datasetService = datasetService;
         this.serverUrl = serverUrl; 

diff --git a/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiSetRepository.java b/src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiSetRepository.java
@@ -21,7 +21,6 @@ public class DataverseXoaiSetRepository implements SetRepository {
     private OAISetServiceBean setService;
 
     public DataverseXoaiSetRepository (OAISetServiceBean setService) {
-        super();
         this.setService = setService;
     }
 

diff --git a/src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java b/src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java
@@ -1204,4 +1204,4 @@ public Map<String, String[]> getCurationLabels() {
         }
         return labelMap;
     }
-    }
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -1204,4 +1204,4 @@ public Map<String, String[]> getCurationLabels() { @@
             }
             return labelMap;
         }
-        }
+    }