Fix UploadDatasetFiles Component test #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, wait for RestrictionModal to close before testing Restricted checkbox.
ekraffmiller
changed the title
ekraffmiller
added
FY25 Sprint 14
g-saracca
reviewed
Jan 14, 2025
g-saracca
approved these changes
Jan 14, 2025
|
Tests are passing, merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates UploadDatasetFiles.spec.tsx to avoid race condition errors.
Which issue(s) this PR closes:
Special notes for your reviewer:
I wasn't able to consistently produce this error, so it's hard to tell if this will definitively fix the bug. But there were multiple places where the test referred to a checkbox by the order on the page, not by an id, which could produce problems since the RestrictedModal and the UploadedFiles component both contain multiple checkboxes.
I added a test that the RestrictedModel is closed, and I added testids to multiple elements to make sure the correct checkboxes are being tested.
Suggestions on how to test this:
Review the code, run locally and check the Github actions.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation: