-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured Items - Collection Page #575
Open
g-saracca
wants to merge
86
commits into
develop
Choose a base branch
from
feat/568-featured-items
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
SPA.Q1
Not related to any specific Q1 feature
Size: 10
A percentage of a sprint. 7 hours.
Original size: 10
and removed
Size: 3
A percentage of a sprint. 2.1 hours.
Original size: 3
labels
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 12
FY25 Sprint 12 (2024-12-04 - 2024-12-18)
GREI Re-arch
GREI re-architecture-related
integration
Tasks involving the connection and interaction of UI features with the Dataverse API
Original size: 10
Size: 10
A percentage of a sprint. 7 hours.
SPA: Collection Page
SPA.Q1
Not related to any specific Q1 feature
SPA.Q4.5
Collections page with a more Website-like or CMS look and feel
Waiting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add featured items section in the Collection Page.
Allows users that can edit a collection to create "featured items" that will initially support content and an optional image.
These "featured items" will be shown between the Collection page header and the items list.
Storybook links:
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh 10943-featured-items
.Step 2: Test the feature
<p class="rte-paragraph">Hello world</p>
so those html tags characters also count for the validation.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
Is there a release notes update needed for this change?:
Additional documentation: