-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/425 publish dataset and collection #520
Conversation
Hi @ekraffmiller could you update js-dataverse package version with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekraffmiller , looks awesome! just some minor comments and there is a conflict in package.json
src/sections/dataset/publish-dataset/PublishDatasetHelpText.tsx
Outdated
Show resolved
Hide resolved
src/sections/dataset/publish-dataset/PublishDatasetHelpText.tsx
Outdated
Show resolved
Hide resolved
tests/component/sections/dataset/dataset-publish/PublishDatasetModal.spec.tsx
Show resolved
Hide resolved
tests/component/dataset/infrastructure/mappers/JSDatasetMapper.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks, approving!
tested in local - no issues found. |
What this PR does / why we need it:
Implements the Publish Dataset feature where both the dataset and it's parent collection are not published. In this case, the Publish Dataset Modal allows the user to publish both the dataset and collection at the same time.
Note that this feature depends on a js-dataverse PR that is not yet merged: IQSS/dataverse-client-javascript#199. When it is merged, package.json can be updated to use the latest 'alpha' version.
Which issue(s) this PR closes:
Special notes for your reviewer:
I'm using
feat/461-publish-collection
as the base branch because it contains the integration code to call the Publish Collection js-dataverse use case.Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
This is not a change from the JSF, but here is what the JSF modal looks like. 'Unpublished' is the name of the parent collection.
Is there a release notes update needed for this change?:
Additional documentation: