SPA Lazy Imports #512
Merged
SPA Lazy Imports #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
ekraffmiller
reviewed
Oct 3, 2024
|
@ekraffmiller I added a component test for the AppLoader component and solved merge conflicts 👍🏼 |
ekraffmiller
approved these changes
Oct 7, 2024
GPortas
added
SPA.Q4
|
Ran tests in local, no issues discovered. This will be tested more over time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Applies react lazy imports for page modules. Each page within the SPA application build will be a separate module with its corresponding javascript and css. This will reduce the initial load time, loading only the assets needed for the SPA requesting path.
Which issue(s) this PR closes:
Special notes for your reviewer:
I made changes to the i18n configuration.
Several locale files were deleted and their content was moved to a shared file --
shared.json.Suggestions on how to test this:
Code visual inspection and re-run of tests actions.
This is difficult to test, as it is a progressive performance enhancement, that's why I suggest re running github action tests.
Another option is on your local environment, run
npm run buildat the root folder of the project in this particular branch to see the build result and maybe do the same indevelopbranch and compare them.Does this PR introduce a user interface change? If mockups are available, please link/include them here: No.
Is there a release notes update needed for this change?: No.
Additional documentation: